Fix for unlinked file importer that did not import all importable files (#8444)#8582
Merged
Conversation
Siedlerchr
approved these changes
Mar 19, 2022
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix and also for the explanation!
Codewise lgtm
calixtus
approved these changes
Mar 21, 2022
Member
|
Thank you for your contribution. We would be happy to see more contributions from your side! |
Siedlerchr
added a commit
that referenced
this pull request
Mar 27, 2022
* upstream/main: (104 commits) update test getPart (#8610) Add ControlHelper truncateString tests comments (#8612) Allow using custom SSL certificates (#8583) Fix protectedTerms not stored due to weaklistener (#8609) Fix changelog and version parsing (#8578) Creating more unit tests for NumericFieldComparatorTest (#8604) Fix merge entries dialog exceeding screen size (#8599) StringUtilTest new test for method GetPart (#8594) Use unkown entry type Add semantic scholar (#8575) Add research gate (#8580) fix import of unlinked files (#8444) (#8582) Missed l10n for fetcher fix (#8597) Fix some fetcher test (#8595) Bump slf4j-api from 2.0.0-alpha6 to 2.0.0-alpha7 in /buildSrc (#8589) Bump ikonli-materialdesign2-pack from 12.3.0 to 12.3.1 (#8591) Bump gittools/actions from 0.9.11 to 0.9.13 (#8587) Bump mockito-core from 4.3.1 to 4.4.0 (#8588) Bump flowless from 0.6.8 to 0.6.9 (#8590) Bump ikonli-javafx from 12.3.0 to 12.3.1 (#8592) ... # Conflicts: # src/main/java/org/jabref/gui/EntryTypeViewModel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8444
Not all unlinked local files that are found in a directory were imported correctly due to some race condition.
The import takes place in a UI background thread and the passed closure referenced a list of entries to add. This list was an instance field of another class and not final. In some cases this list was changed/reassigned before the UI thread ran the closure and accessed the list. Therefor some entries were missing after the import.
Manually tested with 256 files.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)