Observable preferences E (FilePreferences)#8165
Merged
Merged
Conversation
koppor
approved these changes
Oct 18, 2021
tobiasdiez
reviewed
Oct 18, 2021
| put(IMPORT_FILENAMEPATTERN, preferences.getFileNamePattern()); | ||
| put(IMPORT_FILEDIRPATTERN, preferences.getFileDirectoryPattern()); | ||
| putBoolean(DOWNLOAD_LINKED_FILES, preferences.shouldDownloadLinkedFiles()); | ||
| EasyBind.subscribe(filePreferences.mainFileDirectoryProperty(), newValue -> put(MAIN_FILE_DIRECTORY, filePreferences.getFileDirectory().map(Path::toString).orElse(""))); |
Member
There was a problem hiding this comment.
Subscripe runs the lambda immediately, which leads to an unnecessary write of the preferences. Easybind.listen should be used instead. https://github.com/tobiasdiez/EasyBind#subscribe-to-values
Siedlerchr
approved these changes
Oct 19, 2021
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
lgm from my side. Just do what Tobias said
Member
Author
|
done |
5 tasks
Siedlerchr
added a commit
that referenced
this pull request
Oct 22, 2021
…idth * upstream/main: Observable preferences E (FilePreferences) (#8165) More checkstyle fixes Fix checkstyle Remove Elsevier test Pass-through base URL to allow for relative URL resolution Use customBase also at DoiResolution (if enabled) Add some code comments Revert "Add first try to check for content type" Add first try to check for content type Add test for paywalled articles Change from http to https for the referrer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8142 #8164
Removed also deprecated method setFile in ParserResult
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)