Generate an entry from ID#8129
Conversation
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
…to generateEntryFromId merge changes in changelog
merge jabref main commits
tobiasdiez
left a comment
There was a problem hiding this comment.
Thanks for your work. Some suggestions from my side about the general code structure / flow.
This reverts commit 871e413. revert to trying fetchers because of issue with parser methods
calixtus
left a comment
There was a problem hiding this comment.
I like that feature very much. Thank you for adressing the remaining issues. Looks good to me!
koppor
left a comment
There was a problem hiding this comment.
Small nitpick comments remain 😇
koppor
left a comment
There was a problem hiding this comment.
Since a few hours, I am working with the feature, and it works great. One micro thing, then it is good to go from my side
|
In case an entry already exists ...
... and error is thrown
Is it possible to display "Entry already exists"? |
|
When an error occurs, the error should be included in the error message somehow. Maybe reuse the https://doi.org/10.1109/VISSOFT52517.2021.00013 always leads to the error popup. OK, it is an invalid DOI. Maybe, the error message can be routed to the user? |
|
I've included the exception messages in the update-messages of the background-task, now it gives more specific feedback. |
There was a problem hiding this comment.
l10n consistency test
org.opentest4j.AssertionFailedError: Obsolete keys found in language properties file:
Entry could not be created
- CHECK IF THE KEY IS REALLY NOT USED ANYMORE
- REMOVE THESE FROM THE ENGLISH LANGUAGE FILE
==> expected: <[]> but was: <[Entry could not be created]>
|
Yeah! This looks good now 🥇 Thanks for the patience and I hope we didn't annoy you with our nitpicking :) |
Fixes #4183
Adds new code segment in JabrefFrame to handle a new popover.
Adds multiple new files:
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)