Only use Grobid when enabled#8042
Merged
Merged
Conversation
calixtus
approved these changes
Aug 31, 2021
Siedlerchr
approved these changes
Aug 31, 2021
koppor
pushed a commit
that referenced
this pull request
Sep 1, 2021
) * Proposal using obserables * Added some flesh to poc * Refactored ImporterPreferences to new preferences logic and fixed some ide suggestions * Update EntryEditor.java * Only use Grobid when enabled (#8042) * Refactored ProtectedTermsPreferences to observable prefs * Fixed ProtectedTermsTab * Reworked context menu and improved visuals of ProtectedTermsTab * Fixed merge error * Refactored MrDlibPreferences to prefrences observables * Refactored EntryEditorpreferences to observable preferences * Fixed error and remark, made some small visual improvements on ProtectedTermsTab Co-authored-by: Tobias Diez <tobiasdiez@gmx.de> Co-authored-by: Benedikt Tutzer <btut@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)