Skip to content

Remove explicit XMP import for PDFs#8040

Merged
Siedlerchr merged 2 commits into
JabRef:mainfrom
btut:cleanupFindUnlinkedFiles
Aug 31, 2021
Merged

Remove explicit XMP import for PDFs#8040
Siedlerchr merged 2 commits into
JabRef:mainfrom
btut:cleanupFindUnlinkedFiles

Conversation

@btut

@btut btut commented Aug 31, 2021 •
edited by calixtus
Loading

Copy link
Copy Markdown
Contributor

Since XMP is imported by the MergeMetadataImporter anyways, there is no need to do it explicitly. This also respects the same prioritization that is used when importing PDFs.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@btut btut self-assigned this Aug 31, 2021
@btut btut added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 31, 2021
@Siedlerchr Siedlerchr merged commit aa81b99 into JabRef:main Aug 31, 2021
Siedlerchr added a commit that referenced this pull request Aug 31, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into newGlobalSearch
715d068 
* upstream/main:
  Switch to archive.org for site.icu-project.org
  Add Java Profiler
  Fix output when closing JabRef while indexing (#8043)
  Remove explicit XMP import for PDFs (#8040)
  Fix crosses
  Stop indexing on cancel (#8039)
  Write embedded bib in addition to XMP metadata (#8037)
  Cleanup preferences (#8036)
  Fix Search dark mode theme (#8028)
  Allow the search to return multiple entries. (#8038)
  Refactored GroupTree.fxml to plain java (#8035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

Assignees

@btut btut

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@btut @Siedlerchr @calixtus