Refactor processCitation in GrobidService to match processPdf#8003
Merged
Conversation
5 tasks
Siedlerchr
approved these changes
Aug 20, 2021
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
At least better than assertTrue. I would prefer if the response deliverd by the processCitaiton would be directly a BibEntry instead of a string, so you could compare two bib entries:
Contributor
Author
I agree that would make it more consistent with processPDF, so I changed it. |
Siedlerchr
reviewed
Aug 20, 2021
Siedlerchr
reviewed
Aug 20, 2021
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Answers; | ||
|
|
||
| import static org.junit.Assert.assertTrue; |
Member
There was a problem hiding this comment.
You have the wrong junit, it. must be import static org.junit.jupiter.api.Assertions.assertTrue;
Siedlerchr
approved these changes
Aug 20, 2021
Member
|
Much better now! :) |
Siedlerchr
added a commit
that referenced
this pull request
Aug 20, 2021
* upstream/main: (110 commits) Extract PushTo names into model (#8005) Refactor processCitation in GrobidService to match processPdf (#8003) Improved progress indication for fulltext-index operations (#7981) Reordered Pdf-Importer priorities (#8001) Implement more pdf importers (#7947) Adding icon picker for group dialog issue#6142 (#7776) Fix possible NPE in exporter with empty charset (#7979) Fix icon color (#7994) Bump slf4j-api from 2.0.0-alpha2 to 2.0.0-alpha4 (#7991) Bump classgraph from 4.8.112 to 4.8.114 (#7990) Bump mariadb-java-client from 2.7.3 to 2.7.4 (#7992) Bump jsoup from 1.14.1 to 1.14.2 (#7993) New yaml issue template (#7983) [Bot] Update CSL styles (#7985) Reordered items in main table right-click menu (#7952) Fulltext Index: Only index local pdf files (#7980) Bump WyriHaximus/github-action-wait-for-status from 1.3 to 1.4 (#7973) Bump byte-buddy-parent from 1.11.9 to 1.11.12 (#7974) Bump classgraph from 4.8.110 to 4.8.112 (#7975) Bump checkstyle from 8.45 to 8.45.1 (#7978) ... # Conflicts: # src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GrobidService.processCitation now returns an Optional to match the signature of processPDF.
This also makes the tests more expressive, as we can compare the BibEntry to an expected BibEntry instead of comparing Strings.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)