Conversation
This was referenced Jun 27, 2021
calixtus
approved these changes
Jun 27, 2021
calixtus
left a comment
Member
There was a problem hiding this comment.
Took me a while to understand. But now I think it's good!
Siedlerchr
approved these changes
Jun 27, 2021
|
JabRef 5.3--2021-06-27--aa60dd6 i.e., after today's patch, I'm afraid I still see an exception, with Customized Preview Style and also with all the others, but seemingly randomly (sometimes there's no popup, sometimes there is). Or did I pull a version from main too soon?
|
Member
|
I think this is a different error, related to the list itself |
Siedlerchr
added a commit
that referenced
this pull request
Jun 30, 2021
* upstream/main: (26 commits) Add unit test to four test classes (#7651) Fix IEEE test (#7852) New Crowdin updates (#7859) Fix markdown syntax of ADRs add missing l10n (#7857) New Crowdin updates (#7847) Bump mockito-core from 3.11.1 to 3.11.2 (#7856) Bump checkstyle from 8.43 to 8.44 (#7855) Fix for issue #4652: Add Find Unlinked Files Filter based on Date (#7846) Fix for entering a backslash in the custom entry preview dialog (#7851) Fixed INSPIREFetcherTest Fixed TitleFetcherTest Ignore baeldung.com and tldrlegal.com from out link checks New Crowdin updates (#7845) New Crowdin updates (#7843) Refactoring and addition of unit tests (#7597) CLI option to write XMP metadata to pdfs (#7814) Add query validation for web search (#7809) change eclipse default output dir (#7842) Bump lucene-queryparser from 8.8.2 to 8.9.0 (#7835) ...
Siedlerchr
added a commit
that referenced
this pull request
Jul 4, 2021
…kflow-for-slr-search * upstream/main: (31 commits) New translations JabRef_en.properties (German) (#7868) Fix test "higherTrustLevelWins()" (#7866) Change WM_CLASS to jabref (#7858) [Bot] Update CSL styles (#7865) Add unit test to four test classes (#7651) Fix IEEE test (#7852) New Crowdin updates (#7859) Fix markdown syntax of ADRs add missing l10n (#7857) New Crowdin updates (#7847) Bump mockito-core from 3.11.1 to 3.11.2 (#7856) Bump checkstyle from 8.43 to 8.44 (#7855) Fix for issue #4652: Add Find Unlinked Files Filter based on Date (#7846) Fix for entering a backslash in the custom entry preview dialog (#7851) Fixed INSPIREFetcherTest Fixed TitleFetcherTest Ignore baeldung.com and tldrlegal.com from out link checks New Crowdin updates (#7845) New Crowdin updates (#7843) Refactoring and addition of unit tests (#7597) ... # Conflicts: # src/main/resources/l10n/JabRef_en.properties
Member
Author
|
@wujastyk This is a different issue. Could you please open a separate issue in our issue tracker so that we can track it properly? 😇 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #7526 (besides #7526 (comment)). When entering a backslash, JabRef does not throw an exception any more.
I thought long about using Optionals for a good code quality (see https://github.com/JabRef/jabref/pull/7539/files#r611956179). After discussing with @calixtus, I think, this is still an exertional case and should be treated as such. I changed the implementation to return the declared exception only and added tests.
The exception is already properly handled in at
org.jabref.logic.layout.TextBasedPreviewLayout#setText, thus I did not need to touch that code.CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)