Skip to content

Oobranch f : add frontend#7791

Merged
calixtus merged 55 commits into
JabRef:mainfrom
antalk2:oobranch-F
Sep 1, 2021
Merged

Oobranch f : add frontend#7791
calixtus merged 55 commits into
JabRef:mainfrom
antalk2:oobranch-F

Conversation

@antalk2

@antalk2 antalk2 commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Add frontend: connects backend and style. Provides base for implementing GUI actions.

antalk2 added 30 commits May 27, 2021 23:15
@antalk2
step0 : start model/openoffice, logic/openoffice/style
a50cc79
@antalk2
correction: import order
d93bd56
@antalk2
add general utilities
c9b72e9
@antalk2
add UNO utilities, move CreationException, NoDocumentException
381a549
@antalk2
Xlint:unchecked model/openoffice/util
f94c1f6
@antalk2
add ootext
f9a8176
@antalk2
add rangesort
6d013f1
@antalk2
add compareStartsUnsafe, compareStartsThenEndsUnsafe
0434579
@antalk2
add Tuple3
3c45a8a
@antalk2
add ootext
32f7a43
@antalk2
add rangesort
6bae6b4
@antalk2
delNamesArray size correction
314902c
@antalk2
rangeSort update
dfe18bc
@antalk2
Merge remote-tracking branch 'origin/oobranch-C' into oobranch-C
c9f4e57
@antalk2
cleanup
6e4c7c2
@antalk2
style additions
9388b2a
@antalk2
add backend
d2a53c7
@antalk2
add frontend
0fed618
@antalk2
checkstyle on tests
88cab9c
@antalk2
add missing message
b7aaf2a
@antalk2
add backend
0fa9a4c
@antalk2
Merge remote-tracking branch 'origin/oobranch-E' into oobranch-E
946242f
@antalk2
add frontend
a5b7a05
@antalk2
Merge remote-tracking branch 'origin/oobranch-F' into oobranch-F
765f570
@antalk2
apply oobranch-[DEF]-update.patch
4f939b2
@antalk2
Merge remote-tracking branch 'upstream/main' into oobranch-F
e93ef46
@antalk2
not using RangeSet
9f5b148
@antalk2
use StringUtil.isNullOrEmpty
7fa8501
@antalk2
no natural sort for ComparableMark
b31cfd7
@antalk2
in response to review
a2d913a 
JabRef#7788 (review)

- more use of StringUtil.isNullOrEmpty
- private final XTextRangeCompare cmp;
- List<V> partition = partitions.computeIfAbsent(partitionKey, _key -> new ArrayList<>());
- visualSort does not throw WrappedTargetException, NoDocumentException
- set renamed to comparableMarks
antalk2 added 25 commits July 10, 2021 10:49
@antalk2
use {@code }, PMD suggestions
ab6fbe1
@antalk2
Merge remote-tracking branch 'upstream/main' into oobranch-F
8d94e5b
@antalk2
update logic/style from improve-reversibility-rebased-03
daf64d4
@antalk2
update model/style from improve-reversibility-rebased-03
29d8555
@antalk2
replaced single-character names in OOBibStyle.java (in changed part)
76ded20
@antalk2
some longer names in OOBibStyleGetCitationMarker.java
9fa4e13
@antalk2
drop normalizePageInfos, use 'preferred' and 'fallback' in getAuthorL…
5d447ec 
…astSeparatorInTextWithFallBack
@antalk2
checkstyle
43ac154
@antalk2
use putIfAbsent
c6fa7b6
@antalk2
use "{}" with LOGGER
b085f5e
@antalk2
use Objects.hash and Objects.equals in CitationLookupResult
17886d0
@antalk2
simplified CitedKey.getBibEntry
7d259e0
@antalk2
more use of "{}" in LOGGER
6de9fe5
@antalk2
more use of "{}" in LOGGER
80ae0b1
@antalk2
more use of "{}" in LOGGER
eeb9a58
@antalk2
Citation.lookup: use streams
6c4aee6
@antalk2
Citation.lookup: Optional::get before findFirst
822dc05
@antalk2
Merge remote-tracking branch 'upstream/main' into oobranch-F
9273932
@antalk2
putIfAbsent returns null for new entry
75216e9
@antalk2
What is 52 in Backend52
4dbb6cd
@antalk2
apply 2021-08-20-a/oobranch-E-update.patch
35c6c8f 
Brings oobranch-E up to
89b0968 @ origin/improve-reversibility-rebased-03 Merge remote-tracking branch 'upstream/main' into improve-reversibility-rebased-03
@antalk2
sync to improve-reversibility-rebased-03 cb13256
3eb7a7f 
commit cb13256 (HEAD -> improve-reversibility-rebased-03, origin/improve-reversibility-rebased-03)
Author: Antal K <antalk2@gmail.com>
Date:   Fri Aug 20 11:39:39 2021 +0200

    align dots
@antalk2
Merge remote-tracking branch 'upstream/main' into oobranch-F
fefe7d8
@antalk2
longer name
131f386
@antalk2
follow some PMD suggestions
ed8fb0d
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 1, 2021
Siedlerchr
Siedlerchr approved these changes Sep 1, 2021
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@calixtus calixtus merged commit 69550d3 into JabRef:main Sep 1, 2021
Siedlerchr added a commit that referenced this pull request Sep 2, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into newGlobalSearch
bdc5e95 
* upstream/main:
  Enable copy&paste for IntelliJ run configuration
  GitBook: [main] one page modified
  GitBook: [main] one page modified
  GitBook: [main] 19 pages and 6 assets modified
  Refine documentation
  Oobranch f : add frontend (#7791)
  Observable Preferences C (General) (#8047)
  Welcome btut 🎉
  Observable preferences B (ProtectedTerms, EntryEditor and MrDlib) (#8046)
  Refine howto (#8049)
  Decision on handling of localized preferences.
  Added option to import CFF files (#7946)
  Observable preferences A (Appearance and Importer) (#8041)
  Squashed 'buildres/csl/csl-locales/' changes from ec6d62a9e7..7a507fc008
  Squashed 'buildres/csl/csl-styles/' changes from ec4a4c0..2b37392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antalk2 @Siedlerchr @calixtus