Refactor NoBibTexFieldCheckerTest to increase mutation coverage#7697
Merged
Conversation
…rage 1. Switched to using parametrized test 2. Covers missing conditions
calixtus
approved these changes
May 3, 2021
koppor
requested changes
May 3, 2021
koppor
left a comment
Member
There was a problem hiding this comment.
At first, it looks good. Some minor remark remaining
Comment on lines
+26
to
+39
| Arguments.of(new UnknownField("fieldNameNotDefinedInThebiblatexManual"), Collections.emptyList()), | ||
|
|
||
| // these fields are displayed by JabRef as default | ||
| Arguments.of(StandardField.ABSTRACT, Collections.emptyList()), | ||
| Arguments.of(StandardField.COMMENT, Collections.emptyList()), | ||
| Arguments.of(StandardField.DOI, Collections.emptyList()), | ||
| Arguments.of(StandardField.URL, Collections.emptyList()), | ||
|
|
||
| // these fields are not recognized as biblatex only fields | ||
| Arguments.of(StandardField.ADDRESS, Collections.emptyList()), | ||
| Arguments.of(StandardField.INSTITUTION, Collections.emptyList()), | ||
| Arguments.of(StandardField.JOURNAL, Collections.emptyList()), | ||
| Arguments.of(StandardField.KEYWORDS, Collections.emptyList()), | ||
| Arguments.of(StandardField.REVIEW, Collections.emptyList()) |
Member
There was a problem hiding this comment.
Each thing gets , Collections.emptyList() as paramter. Thus, this can be removed.
Maybe, even Stream.of(List.of(StandardField.ABSTRACT, StandardField.COMMENT, ...) can be used.
Suggested change
| Arguments.of(new UnknownField("fieldNameNotDefinedInThebiblatexManual"), Collections.emptyList()), | |
| // these fields are displayed by JabRef as default | |
| Arguments.of(StandardField.ABSTRACT, Collections.emptyList()), | |
| Arguments.of(StandardField.COMMENT, Collections.emptyList()), | |
| Arguments.of(StandardField.DOI, Collections.emptyList()), | |
| Arguments.of(StandardField.URL, Collections.emptyList()), | |
| // these fields are not recognized as biblatex only fields | |
| Arguments.of(StandardField.ADDRESS, Collections.emptyList()), | |
| Arguments.of(StandardField.INSTITUTION, Collections.emptyList()), | |
| Arguments.of(StandardField.JOURNAL, Collections.emptyList()), | |
| Arguments.of(StandardField.KEYWORDS, Collections.emptyList()), | |
| Arguments.of(StandardField.REVIEW, Collections.emptyList()) | |
| Arguments.of(new UnknownField("fieldNameNotDefinedInThebiblatexManual")), | |
| // these fields are displayed by JabRef as default | |
| Arguments.of(StandardField.ABSTRACT), | |
| Arguments.of(StandardField.COMMENT), | |
| Arguments.of(StandardField.DOI), | |
| Arguments.of(StandardField.URL), | |
| // these fields are not recognized as biblatex only fields | |
| Arguments.of(StandardField.ADDRESS), | |
| Arguments.of(StandardField.INSTITUTION), | |
| Arguments.of(StandardField.JOURNAL), | |
| Arguments.of(StandardField.KEYWORDS), | |
| Arguments.of(StandardField.REVIEW) |
Contributor
Author
There was a problem hiding this comment.
Code is updated as suggested. :)
koppor
approved these changes
May 3, 2021
Siedlerchr
added a commit
that referenced
this pull request
May 4, 2021
* upstream/main: (354 commits) Fix ScienceDirect fetcher (#7684) Refactor NoBibTexFieldCheckerTest to increase mutation coverage (#7697) Update Gradle from 6.8.3 to 7.0 (#7619) Fixes Jabref#7305: the RFC fetcher is not compatible with the draftFix for issue 7305 (#7674) Refactoring existing unit tests (#7693) cover boundary cases & add more unit tests (#7694) Bump classgraph from 4.8.104 to 4.8.105 (#7688) Bump java-diff-utils from 4.9 to 4.10 (#7692) Fix arXiv fetcher tests (#7686) Make key for ScienceDirect configurable (#7683) migration of timestamp (#7671) Fix CCSB and DOAJ (#7426) [Bot] Update CSL styles (#7680) MS Office XML: Export month name (#7677) linkfix (#7678) readd fix (#7675) Fix threading cleanup in performSearch (#7672) add missing changelog delete bug fix (#7580) Add more unit tests to three gui classes (#7636) ... # Conflicts: # build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contributes to issue #6207, which is to add more unit tests or improve existing ones. I used Pitest to compute the mutation coverage and found that some conditions were not covered in the unit test and some conditions tested were redundant because they would not be reached. Following are the changes:
Before:
After:
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)