Fixes Jabref#7660 Unable to download some arXiv links if the "eprint" field is missing#7663
Merged
Merged
Conversation
1. Run EprintCleanup on a copy of the entry the ArXiv fetcher is fetching before getting arXiv id from the eprint field; 2. Add two test method. One finds full text with title containing colon and journal, while another finds full text with title containing colon and url.
tobiasdiez
approved these changes
Apr 23, 2021
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Wow that was quick 🚀 . Code looks good to me! Thanks for your contribution.
Siedlerchr
reviewed
Apr 23, 2021
| } | ||
|
|
||
| private List<ArXivEntry> searchForEntries(BibEntry entry) throws FetcherException { | ||
| entry = (BibEntry) entry.clone(); |
Contributor
Author
There was a problem hiding this comment.
If we do clean up on the original entry, its fields will be changed but I think we needn't change fields here because it is just a search.
Contributor
Author
It is your advice that makes me efficient! At the beginning I try to ignore colons in title to solve this problem but it seems not so good. |
Siedlerchr
added a commit
that referenced
this pull request
Apr 24, 2021
…om.tngtech.archunit-archunit-junit5-api-0.18.0 * upstream/main: Fix exception when searching (#7659) Fixes Jabref#7660 (#7663) Fix for issue 5850: Journal abbreviations in UTF-8 not recognized (#7639) Fix SSLHandshake Exception by using bypass (#7657) Fix for issue 7633: Unable to download arXiv pdfs if Title contains curly brackets (#7652) Fix#7195 partly Opacity of disabled icon-buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7660
Brief summary
Problem
When finding full text, this BibTeX reference works:
But when
eprintfield is missing, no full text will be found:Solution
Since the title contains colon and arXiv uses colon to represent key and value, the title may be recognized mistakenly. So use other fields to get the eprint field to avoid this problem. Thanks to the advice from @tobiasdiez .
Screenshots
After fix:

CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)