Feature add git workflow for slr search#7625
Merged
Merged
Conversation
calixtus
requested changes
Apr 16, 2021
calixtus
left a comment
Member
There was a problem hiding this comment.
After a very quick first look good work, yet some smaller issues with the mvvm pattern.
| } | ||
|
|
||
| @FXML | ||
| public void selectStudyDirectory() { |
Member
There was a problem hiding this comment.
Logic should go to the viewmodel
tobiasdiez
reviewed
Apr 16, 2021
tobiasdiez
reviewed
Apr 16, 2021
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
LGTM.
Is it possible to make git management opt-in? I think most of our users don't use git.
Member
Maybe, we can just omit the "git push" thing. And the other things should "just work", because jgit is used instead of a local git configuration. - We opted for using git, because it provides us a history of the searches out of the box. We did not want to implement a new version-control system. 😇 |
Siedlerchr
approved these changes
May 24, 2021
calixtus
requested changes
May 29, 2021
calixtus
left a comment
Member
There was a problem hiding this comment.
Took a deeper look into your code. Most of it looks good though i have some remarks on code style.
…kflow-for-slr-search * upstream/main: (31 commits) New translations JabRef_en.properties (German) (#7868) Fix test "higherTrustLevelWins()" (#7866) Change WM_CLASS to jabref (#7858) [Bot] Update CSL styles (#7865) Add unit test to four test classes (#7651) Fix IEEE test (#7852) New Crowdin updates (#7859) Fix markdown syntax of ADRs add missing l10n (#7857) New Crowdin updates (#7847) Bump mockito-core from 3.11.1 to 3.11.2 (#7856) Bump checkstyle from 8.43 to 8.44 (#7855) Fix for issue #4652: Add Find Unlinked Files Filter based on Date (#7846) Fix for entering a backslash in the custom entry preview dialog (#7851) Fixed INSPIREFetcherTest Fixed TitleFetcherTest Ignore baeldung.com and tldrlegal.com from out link checks New Crowdin updates (#7845) New Crowdin updates (#7843) Refactoring and addition of unit tests (#7597) ... # Conflicts: # src/main/resources/l10n/JabRef_en.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Toolbar actions for starting a new SLR and continuing an existing SLR.
Besides the documentation this PR is complete.
I will create a documentation parallel to this one sometime this week.
Toolbar entries:
Starting new study UI:
TODO: Add & Update documentation: JabRef/user-documentation#333
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)