Add simple unit tests#7544
Merged
Merged
Conversation
new unit tests for EscapeAmpersandsFormatterTest
new unit tests for FieldComparatorTest.java
new unit test for BooktitleChecker class
new unit tests for ISBN-13 control digit partition
more unit tests for ShortMonthFormatter considering new partitions
more unit tests for ToLowerCaseTest.java considering different partitions
more unit tests for ISSNCheckerTest.java considering different boundaries
calixtus
reviewed
Mar 27, 2021
koppor
requested changes
Apr 12, 2021
koppor
left a comment
Member
There was a problem hiding this comment.
Thank you for the work; some small comments remain ^^
koppor
reviewed
Apr 12, 2021
koppor
reviewed
Apr 12, 2021
koppor
reviewed
Apr 12, 2021
koppor
reviewed
Apr 12, 2021
koppor
reviewed
Apr 12, 2021
Contributor
Author
koppor
approved these changes
May 6, 2021
Siedlerchr
added a commit
that referenced
this pull request
May 15, 2021
* upstream/main: (71 commits) [Bot] Update CSL styles (#7735) Fix for issue 6966: open all files of multiple entries (#7709) Add simple unit tests (#7696) Add simple unit tests (#7543) Update check-outdated-dependencies.yml Added preset for new entry keybindings and reintroduced defaults (#7705) Select the entry which has smaller dictonary order when merge (#7708) Update CHANGELOG.md fix: make more fields, fomatters, ids and languages sorted by alphabetical order (#7717) Bump libreoffice from 7.1.2 to 7.1.3 (#7721) Bump unoloader from 7.1.2 to 7.1.3 (#7724) Bump org.beryx.jlink from 2.23.7 to 2.23.8 (#7723) Bump org.openjfx.javafxplugin from 0.0.9 to 0.0.10 (#7725) fix: make fields sorted by lexicographical order (#7711) Fix tests Refactoring existing unit tests (#7687) Refactoring and addition of unit tests (#7581) Refactor simple Unit Tests (#7571) Add simple unit tests (#7544) add and extend unit tests (#7685) ...
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 2, 2023
* Inline LOGGER.debug * Move out work in constructor to method * Streamline code * Same comments * Fix variable name * "Flatten" SaveOrder if OrderType.TABLE * WIP: Show diff in UI * Make it scrollable Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> * WIP: Try to fix content selector diff Co-authored-by: Christoph <siedlerkiller@gmail.com> * Add some debugging * Update preferences immediatly after change (and not sometime later) * Fix serialization of SaveOrder * Add CHANGELOG.md entry * Fix mapping of SaveOrderConfig * Introduce SelfContainedSaveOrder * More SelfContainedSaveOrder * Remove ref to PrefsService * Compile fix * Made OrFields NOT extending LinkedHashSet<Field> * Fix hillarious bug * Fixed tests * Try to fix FieldComparators for OrFields * Fix order of null comparisons Refs tests of #7544 * Fix checkstyle * Add missing equals, hashcode and toString * Fix checkstyle * Restore test files * Fix OpenRewrite * Fix modernizer * Update CHANGELOG.md * Fix NPE --------- Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added some simple unit tests that will increase code coverage / branch coverage.
They contribute to issue #6207
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)