Fixes issue of Changing font size makes font size field too small#7398
Merged
Conversation
Contributor
Author
|
Any idea why the check "Deployment / Create installer and portable version for macOS (pull_request) " fails? Under the step |
Member
|
The OSX build requires some secrets that aren't available in forks. So simply ignore it. Maybe I can disable the Mac build for forks |
tobiasdiez
approved these changes
Jan 31, 2021
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
LGTM! Welcome to JabRef, and thanks a lot for your contribution.
calixtus
approved these changes
Feb 1, 2021
calixtus
left a comment
Member
There was a problem hiding this comment.
Looks good. Thanks. Merging now.
Siedlerchr
added a commit
that referenced
this pull request
Feb 1, 2021
* upstream/master: Bump archunit-junit5-api from 0.15.0 to 0.16.0 (#7407) Bump classgraph from 4.8.98 to 4.8.102 (#7401) Bump archunit-junit5-engine from 0.15.0 to 0.16.0 (#7402) Bump mariadb-java-client from 2.7.1 to 2.7.2 (#7406) Bump org.beryx.jlink from 2.23.2 to 2.23.3 (#7400) Bump checkstyle from 8.39 to 8.40 (#7404) Ignore codecov status for automerge Fixes issue of Changing font size makes font size field too small (#7398) fix "Alt + keyboard shortcuts do not work" (#7379) Fixed invisible file path in the dark theme (#7396) Fix File Filter and some layout issues (#7385) Feature/implement complex queries (#7350) Change format for study definition to yaml (#7126) Fix handling of URL in file field (#7347) Fix expansion of bracketed expressions in RegExpBasedFileFinder (#7338)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As the preferred width for the fontsize spinner under prefrences/appearence was set to a fixed pixel size, I changed it to use the
emmeasure instead. A style class calledfontsizeSpinnerwas added toBase.csswith this change.Fixes #7085.
Screenshots: