Add migration to special field#7368
Merged
koppor merged 6 commits intoJan 19, 2021
Merged
Conversation
tobiasdiez
previously approved these changes
Jan 19, 2021
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks! Looks good to me, without any of the usual comments and suggestions ;-)
Siedlerchr
reviewed
Jan 19, 2021
koppor
requested changes
Jan 19, 2021
koppor
left a comment
Member
There was a problem hiding this comment.
I think, this is a very short implementation. Looks good.
Could you remove org.jabref.logic.specialfields.SpecialFieldsUtils and org.jabref.logic.specialfields.SpecialFieldsUtilsTest, because this migration should make them obsolete.
Co-authored-by: Christoph <siedlerkiller@gmail.com>
26dfa46
tobiasdiez
reviewed
Jan 19, 2021
c20ed92 to
be9aca4
Compare
koppor
approved these changes
Jan 19, 2021
koppor
left a comment
Member
There was a problem hiding this comment.
I was thinking, if we should check for importFormatPreferences.isKeywordSyncEnabled().
The "risk" is that "common" words such as read, skimmed, revelant, and printed could always automatically be moved from keywords to special fields and users will complain that keywords are lost. I think, this risk is low, thus I approve.
Siedlerchr
added a commit
that referenced
this pull request
Jan 20, 2021
* upstream/master: GitBook: [master] 3 pages and 32 assets modified Add migration to special field (#7368) GitBook: [master] 5 pages and 29 assets modified
Siedlerchr
added a commit
that referenced
this pull request
Jan 22, 2021
…dtask * upstream/master: Upgrade citeproc to 3.x snapshot without graal (#7370) Fix Exception if no AzureInstrumentationKey is available (#7373) Update snapcraft source url (#7372) Fix checkstyle and adjust language GitBook: [master] 3 pages and 32 assets modified Add migration to special field (#7368) GitBook: [master] 5 pages and 29 assets modified Modify message at the duplicates found dialog (#7231) Fixes miss-parsed names in `AutomaticPersonsGroup` (#7228) Fix an issue where the password for a shared SQL database was only remembered if it was the same as the username (#7364) Fix harvard exporter by changing AuthorsFormatter (#7355) Bump styfle/cancel-workflow-action from 0.6.0 to 0.7.0 (#7363) Bump mockito-core from 3.7.0 to 3.7.7 (#7360) Bump org.beryx.jlink from 2.23.1 to 2.23.2 (#7361) Bump libreoffice from 7.0.3 to 7.0.4 (#7362) Export full month name instead of number in ms office (#7358)
Siedlerchr
added a commit
to JabRef/jabref-koppor
that referenced
this pull request
Jan 26, 2021
* upstream/master: (217 commits) Fix handling of URL in file field (JabRef#7347) Fix expansion of bracketed expressions in RegExpBasedFileFinder (JabRef#7338) Refactor unlinked files (JabRef#7209) Add pressing enter when the search field is focused as a way to trigger search (JabRef#7377) Upgrade citeproc to 3.x snapshot without graal (JabRef#7370) Fix Exception if no AzureInstrumentationKey is available (JabRef#7373) Update snapcraft source url (JabRef#7372) Fix checkstyle and adjust language GitBook: [master] 3 pages and 32 assets modified Add migration to special field (JabRef#7368) GitBook: [master] 5 pages and 29 assets modified Modify message at the duplicates found dialog (JabRef#7231) Fixes miss-parsed names in `AutomaticPersonsGroup` (JabRef#7228) Fix an issue where the password for a shared SQL database was only remembered if it was the same as the username (JabRef#7364) Fix harvard exporter by changing AuthorsFormatter (JabRef#7355) Bump styfle/cancel-workflow-action from 0.6.0 to 0.7.0 (JabRef#7363) Bump mockito-core from 3.7.0 to 3.7.7 (JabRef#7360) Bump org.beryx.jlink from 2.23.1 to 2.23.2 (JabRef#7361) Bump libreoffice from 7.0.3 to 7.0.4 (JabRef#7362) Export full month name instead of number in ms office (JabRef#7358) ... # Conflicts: # external-libraries.md # src/main/java/module-info.java # src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogViewModel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates all occurrences of special field values in the keywords into their respective special fields.
Fixes #6840.