Skip to content

Update to gradle 6.8#7324

Merged
koppor merged 2 commits into
masterfrom
updateGradle
Jan 11, 2021
Merged

Update to gradle 6.8#7324
koppor merged 2 commits into
masterfrom
updateGradle

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Jan 10, 2021

Copy link
Copy Markdown
Member

Added hint on workaround

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Added hint on workaround
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 10, 2021
@Siedlerchr Siedlerchr requested a review from koppor January 10, 2021 17:34
@koppor

koppor commented Jan 10, 2021

Copy link
Copy Markdown
Member

@Siedlerchr had the impression that JabRef was slower (see JabRef#440 (comment)). Do we need to test it?

@Siedlerchr

Copy link
Copy Markdown
Member Author

I no longer have the impression. 6.8 seems fast again with jabref or it was another bug fix

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • jabref.bat -n -h works (besides the strange output JabRef#486)
  • Did not see performance issues during runtime

Thus, I'll go ahead with merging. We can revert if some developers experience issues.

@koppor koppor merged commit 534b198 into master Jan 11, 2021
@koppor koppor deleted the updateGradle branch January 11, 2021 06:30
Siedlerchr added a commit that referenced this pull request Jan 13, 2021
…dtask

* upstream/master:
  Update guidelines-for-setting-up-a-local-workspace.md (#7339)
  Updates to colored group indicator for cited entries (#7173)
  Add some special fields as default columns (#7286)
  Add a more descriptive path when Directory cannot be found (#7232)
  Bump antlr4 from 4.9 to 4.9.1 (#7327)
  Bump unirest-java from 3.11.09 to 3.11.10 (#7329)
  Bump mockito-core from 3.6.28 to 3.7.0 (#7328)
  Bump antlr4-runtime from 4.9 to 4.9.1 (#7330)
  Bump gittools/actions from v0.9.7 to v0.9.8 (#7331)
  Update to gradle 6.8 (#7324)
  Link to GitHub contributors in about dialog (#7319)
  Fix snapcraft upload (#7263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants