Skip to content

Added eye candy in entry editor context menus#7268

Merged
tobiasdiez merged 5 commits into
masterfrom
entry-editor-eye-candy
Jan 4, 2021
Merged

Added eye candy in entry editor context menus#7268
tobiasdiez merged 5 commits into
masterfrom
entry-editor-eye-candy

Conversation

@calixtus

@calixtus calixtus commented Dec 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds some eye candy in the entry editor editors context menu.

grafik

Sadly, the TextField in the FXChipView is not accessible, so this one lacks eye candy.

Still WIP, I'll see if I can fix some misplaced other menu entries.

Refs #5352

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

calixtus
calixtus commented Dec 31, 2020
View reviewed changes

@calixtus calixtus left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tobiasdiez , I'm currently refactoring the context menu for the field editors. It's still work in progress, but I encountered some design choices of yours I don't understand. Can you help me out here?

Comment thread src/main/java/org/jabref/gui/fieldeditors/contextmenu/EditorContextAction.java Outdated
Comment thread src/main/java/org/jabref/gui/fieldeditors/contextmenu/EditorContextAction.java Outdated
@calixtus

calixtus commented Jan 3, 2021

Copy link
Copy Markdown
Member Author

Well, the context menu is still not perfect (some menu entries are still not created by factory methods, but with CustomMenuEntries to be able to add ToolTips to them, which is - as I see it - fairly uncommon). This results in misplaced labels:
grafik
I did some research but I see no way to preserve the ToolTips and to use standard MenuItems, so I'll leave that as it is. Everything else should be an improvement and using the command pattern this should also prepare some repairs in our broken undo/redo system.

@calixtus calixtus marked this pull request as ready for review January 3, 2021 16:47
Siedlerchr
Siedlerchr approved these changes Jan 3, 2021
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on mac + codewise also lgtm

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 3, 2021
@tobiasdiez tobiasdiez merged commit 0f3b016 into master Jan 4, 2021
@tobiasdiez tobiasdiez deleted the entry-editor-eye-candy branch January 4, 2021 09:43
Siedlerchr added a commit that referenced this pull request Jan 4, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into importerbackgroun…
4b3a922 
…dtask

* upstream/master:
  Added eye candy in entry editor context menus (#7268)
  Bump WyriHaximus/github-action-wait-for-status from v1.2 to v1.3 (#7285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixtus @Siedlerchr @tobiasdiez