Fix DOI fetcher and add documentation on fetcher trust levels#6990
Conversation
tobiasdiez
left a comment
There was a problem hiding this comment.
Thanks!
I still think that Publisher should be a higher priority as Source. They also take the DOI into account, but use the publisher-specific API to get the fulltext url. Thus, they are more reliable than just following the DOI and then trying to guess the PDF path from the webpage.
|
|
Ok, so we have: Publisher_Identifier (use doi or other identifier, uses publisher API), Identifier (general identifier-based), Publisher (not identifier-based), preprint, other I'm not sure if the distinction between publisher with and without identifier is really necessary, but that should make it clear also in the future. |
|
The issue is about full-text fetchers. The issue was that one fetcher implementeation fetches the complete proceedings and the other fetcher fetches the concrete paper. A DOI points to the paper; the publisher fetcher fetches the complete proceedings. This is unintended. I will try to pair-up with @stefan-kolb |
|
We fixed a similarity problem inside the DoiResolution that REALLY caused this issue. |
- remove similarity of links - add citation meta tag <meta name="citation_pdf_url">
9682a6e to
a39f3dc
Compare
tobiasdiez
left a comment
There was a problem hiding this comment.
Generally, LGTM. One question though.
Follow-up toThis reverts #6937in order to add documentation on our decisions taken in 2018.. That PR added a workaround to thing introduced in 15c7981.In this PR,
Small, unlreated changes:
build.properties. Gradle wrote literallynullin the generatedbuild.properties. It was changed to contain""instead of"null"for an unknown keySide note: It seems that 15c7981 accidently committed to the
masterbranch and not using a PR.