Skip to content

Fix the paths in chrome snap hooks#6978

Merged
koppor merged 1 commit into
masterfrom
snapPluginFix
Oct 4, 2020
Merged

Fix the paths in chrome snap hooks#6978
koppor merged 1 commit into
masterfrom
snapPluginFix

Conversation

@LyzardKing

@LyzardKing LyzardKing commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

This PR changes reverts the paths in the snap hooks to the correct one for chrome/chromium.
They were set to look at the mozilla dir for chrome as well, but it's not correct

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor merged commit e954d84 into master Oct 4, 2020
@koppor koppor deleted the snapPluginFix branch October 4, 2020 08:19
Siedlerchr added a commit that referenced this pull request Oct 4, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixFetcher
1a27b82 
* upstream/master:
  Pin application insights (#6972)
  Adapt the short DOI regex (#6977)
  Fix the paths in chrome snap hooks (#6978)
  Adapt test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LyzardKing @koppor