Skip to content

Apply css files correctly to dialogs#6828

Merged
tobiasdiez merged 3 commits into
masterfrom
dialogcss
Sep 1, 2020
Merged

Apply css files correctly to dialogs#6828
tobiasdiez merged 3 commits into
masterfrom
dialogcss

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Aug 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #6039. Doesn't work in all cases (for some strange reason), but in most it does.

Continuation of #6429, so please add LuckyOne09 as co-author.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 31, 2020
@tobiasdiez tobiasdiez mentioned this pull request Aug 31, 2020
Closed
5 tasks
calixtus
calixtus approved these changes Aug 31, 2020
View reviewed changes

@calixtus calixtus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not asleep yet.
Looks good. at least better than before.

@calixtus

calixtus commented Aug 31, 2020

Copy link
Copy Markdown
Member

One linting error

@tobiasdiez tobiasdiez merged commit 26870b7 into master Sep 1, 2020
@tobiasdiez tobiasdiez deleted the dialogcss branch September 1, 2020 10:36
Siedlerchr added a commit that referenced this pull request Sep 1, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
7b68deb 
* upstream/master:
  Enable Merging of BibDatabases (#6689)
  Refactor file preferences (#6779)
  Interrupt all running tasks during shutdown (#6118)
  Fixes #6705 , added icon for multiple identifiers (#6809)
  Apply css files correctly to dialogs (#6828)
  Fix link
  Make template more explicit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Font size increase does not increase preferences font size

2 participants

@tobiasdiez @calixtus