Skip to content

Architecture fix by re-sorting the classes#6825

Merged
koppor merged 18 commits into
masterfrom
archFix
Sep 2, 2020
Merged

Architecture fix by re-sorting the classes#6825
koppor merged 18 commits into
masterfrom
archFix

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Aug 31, 2020

Copy link
Copy Markdown
Member

To be merged after JabCon. Fixes #6697

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

� Conflicts:
�	src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java
�	src/main/java/org/jabref/preferences/JabRefPreferences.java
@github-actions

github-actions Bot commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

The JabRef maintainers will add the following name to the AUTHORS file. In case you want to use a different one, please comment here and adjust your name in your git configuration for future commits.

m-mauersberger

@tobiasdiez tobiasdiez marked this pull request as ready for review September 1, 2020 23:37
@github-actions

github-actions Bot commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

The JabRef maintainers will add the following name to the AUTHORS file. In case you want to use a different one, please comment here and adjust your name in your git configuration for future commits.

chenyuheng

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 2, 2020
@koppor koppor merged commit 1b35f8c into master Sep 2, 2020
@koppor koppor deleted the archFix branch September 2, 2020 11:40
Siedlerchr added a commit that referenced this pull request Sep 2, 2020
@koppor koppor changed the title Arch fix Architecture fix by re-sorting the classes Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing architecture tests

2 participants