Conversation
Member
|
I need to check that with Eclipse first before mergin |
koppor
approved these changes
Aug 27, 2020
koppor
left a comment
Member
There was a problem hiding this comment.
Yeah, IntelliJ automatically uses generated:
Member
|
I'd like to have this in the release. In case there are issues with Eclipse, we will discuss and probably revert the change. |
Member
|
Confirmed: Eclipse works. Checkstyle and codecov needed adjustments as well |
Member
|
Thank you for the quick fix! --> c617d34 |
Siedlerchr
added a commit
that referenced
this pull request
Aug 31, 2020
* upstream/master: (120 commits) Follow up fix for copy paste (#6820) Add CSS Customisation (#6725) Separate signing and notarizing (#6822) Remove checkstyle hack. 8.36 got released (#6816) Feature/enable lucene query parsing (#6799) New release cycle Bump WyriHaximus/github-action-wait-for-status from v1.1.2 to v1.2 (#6814) Bump mockito-core from 3.5.5 to 3.5.7 (#6813) Bump classgraph from 4.8.87 to 4.8.89 (#6812) Bump me.champeau.gradle.jmh from 0.5.0 to 0.5.1 (#6811) Bump checkstyle from 8.35 to 8.36 (#6810) Improve Changelog Refactor edit action (#6808) Fixed typo in BuildInfo (#6807) disable checkstyle for generated fix checkstyle Simplify check-links.yaml (markdown-link-check) (#6720) Rename /gen to /generate (#6800) Disable CSL refresh on push (#6803) New Crowdin updates (#6804) ... # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by #6794 (comment). All generated files are now placed in src/main/generated which is automatically indexed by Intellj. This removes a few configuration steps that are otherwise needed (see #6794). After running
compileJavaonce, the intellj-based compilation and run is sufficient.For 2020.1 it was working, but it stopped now that I upgraded to 2020.2. It seems the generated sources are no longer included in the intellj-based build. As @koppor experience the same issues, I guess this is a bug in Intellj.