Skip to content

Typos in teaching.md#6680

Merged
Siedlerchr merged 2 commits into
JabRef:masterfrom
RetriedAgain:patch-2
Jul 11, 2020
Merged

Typos in teaching.md#6680
Siedlerchr merged 2 commits into
JabRef:masterfrom
RetriedAgain:patch-2

Conversation

@RetriedAgain

Copy link
Copy Markdown
Contributor

Removed a link leading to nothing, a comma and replaced "wirking" through "working".

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Removed a seemingly unnecessary link, a comma and "wirking" through "working"

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Siedlerchr Siedlerchr merged commit 71b0381 into JabRef:master Jul 11, 2020
@RetriedAgain

RetriedAgain commented Jul 11, 2020

Copy link
Copy Markdown
Contributor Author

Hello,
I am new to this, apologies. The tests failed, and then I was confused, and then I tried to change the commit,
-> the link was re-added. I'm not sure if I need to properly test it first. Should I try it again with that markup-stuff, or should I just remove the link? It didn't seem to lead anywhere besides the page itself, but I can't tell if it is truly "broken" then, and if the markup-check would work.
Greetings!

@Siedlerchr

Copy link
Copy Markdown
Member

The link should have led to an anchor (the # sign is used to identify text anchors .e.g headings)

@RetriedAgain

Copy link
Copy Markdown
Contributor Author

Hello again, and thank you for your quick replies.

I think I broke that link, or it was already broken. After the sentence there is a sudden 1, and it doesn't lead me to any other header.

Here the link to the docs where it is for convenience:
https://devdocs.jabref.org/teaching#Ayaankazerouni

Apologies for the inconvenience.
Greetings.

@Siedlerchr

Copy link
Copy Markdown
Member

Ah now I understand it. It's supposed to be a footnote link. If you scroll down to the References section. You see the 1 again.

The problem seems to be that gitbook doesn't support them https://gitbook.canny.io/feature-requests/p/footnotes
So it seems like the 1 should refer to the 1 at the bottom.

Siedlerchr added a commit that referenced this pull request Jul 13, 2020
* upstream/master:
  Add link to homepage of Gradle Test Logger Plugin
  getAgency moved from DOI to DoiFetcher (#6683)
  Update teaching.md (#6681)
  Add JavaFX installation notes (#6679)
  Typos in teaching.md (#6680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants