Fix author formatter for unchanged names#6552
Merged
koppor merged 117 commits intoJun 16, 2020
Merged
Conversation
The original condition is evaluated to false. The substring is shorter than "uni".
Perhaps the assumption should be that the letters are ASCII. If all letters are ASCII checking 'A' <= k.charAt(0) <= 'Z' might make more sense. I am not convinced about doing this with a regex.
Both test cases involves an author name containing department or school without university or institute of technology.
Corporate authors without university/institute of technology
# Conflicts: # src/main/java/org/jabref/logic/bibtexkeypattern/BracketedPattern.java
If the name of an institution can't be split, assume that "School"/"Department" is part of the name.
Minor typos and the "rest" part is now created differently.
Move the fields loop from BibEntryTableViewModel to MainTableFieldValueFormatter.
Store a reference to the used BibDatabase in MainTableFieldValueFormatter with the constructor.
tobiasdiez
requested changes
Jun 16, 2020
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks for the update. Looks already pretty good to me, and I've only few more minor comments.
Co-authored-by: Tobias Diez <tobiasdiez@gmx.de>
…dSMPHz27/jabref into fix-for-issue-6459
koppor
requested changes
Jun 16, 2020
koppor
left a comment
Member
There was a problem hiding this comment.
Thank you for the hard work. I have some code nitpicks.
And a hint to get checkstyle running again:
Please add MainTableFieldValueFormatter.java to
jabref/config/checkstyle/checkstyle.xml
Line 15 in ca06b71
This reverts commit 6155e14
…dSMPHz27/jabref into fix-for-issue-6459
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
…dSMPHz27/jabref into fix-for-issue-6459
Siedlerchr
added a commit
that referenced
this pull request
Jun 20, 2020
* upstream/master: Validates the file path of a TexGroup and fixes Texgroup's "Library has been modified by another program" (#6586) Bump postgresql from 42.2.12 to 42.2.14 (#6610) Add markdown-link-check (#6542) Catch InaccessibleObjectException (#6519) Fix author formatter for unchanged names (#6552) Bump com.simonharrer.modernizer from 1.8.0-1 to 2.1.0-1 Bump org.beryx.jlink from 2.19.0 to 2.20.0 Bump classgraph from 4.8.83 to 4.8.86 Update FileUtilTest.java Update FileUtilTest.java Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635 Update FileUtilTest.java Update MoveFilesCleanupTest.java checkstyle Fix dowmloaded files moved to citaiton key dir
1 task
5 tasks
23 tasks
koppor
pushed a commit
that referenced
this pull request
Jun 1, 2023
6b7fdff8cb Create journal-of-the-american-philosophical-association.csl (#6542) 9bae9efc55 Update german-council-of-economic-experts.csl (#6562) 256250be9c Update springer-vancouver-brackets.csl (#6546) f422ca9c9a Update turabian-fullnote-bibliography.csl (#6540) 2833b5d5d5 Update mots.csl (#6556) 44758704b0 Update and rename harvard-the-university-of-melbourne.csl to dependen… (#6547) 08e65fc8e1 Update ieee-with-url.csl (#6514) 06e98f4387 Fix erroneous comma in ACL in-text citation (#6553) 72e16a19cd Update bibliothek-forschung-und-praxis.csl (#6527) 50bae82394 Create Food and Agriculture Organization of the United Nations (numeric) (#6544) 234a3c35d8 Update bern-university-of-applied-sciences-school-of-agricultural-for… (#6552) 3e9e2d6e93 Fix et al and name settings in universitat bern institut fur sozialanthropologie (#6554) e8e06888fe Update harvard-university-of-the-west-of-england.csl (#6520) dbbe5c1a95 Update united-states-international-trade-commission.csl (#6535) b985431f03 Update american-society-for-horticultural-science.csl (#6543) e1ff9f5546 Sort APA and derivatives on displayed date, not full date (#6545) 7302832d6d Localize original-work-published in APA (#6388) 77a61c0d82 Update united-states-international-trade-commission.csl (#6526) 541807a057 Update the-accounting-review.csl (#6521) 708626357a Update united-states-international-trade-commission git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 6b7fdff8cb0fb45b342e8ac319634bf18168c73d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue created in #6479 where the "Format of author and editor names",
Show names unchangedoption does not resolve umlauts/latex.