Skip to content

Refactor main table preferences#6518

Merged
Siedlerchr merged 13 commits into
masterfrom
refactor_tableprefs
May 28, 2020
Merged

Refactor main table preferences#6518
Siedlerchr merged 13 commits into
masterfrom
refactor_tableprefs

Conversation

@calixtus

@calixtus calixtus commented May 24, 2020

Copy link
Copy Markdown
Member

Follow up to #6509

Merged table preferences, see the screenshot.

grafik

Fixes #6515

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@tobiasdiez

tobiasdiez commented May 25, 2020

Copy link
Copy Markdown
Member

I think the "Enable special fields" should move to another preference tab as this is not really related to the main table. Moreover, is the "Show extra columns" still needed (and what does it do)? Any maybe rename "Natbib style" to what it actually represents (which is actually not clear to me...).

@calixtus

calixtus commented May 25, 2020

Copy link
Copy Markdown
Member Author

'Show extra columns' adds additional columns to the combobox providing a column for every filetype (instead of one column displaying different icons for each filetype). In refactoring the tabs to the mvvm pattern we discussed removal of these columns, but decided to keep them, as they were not really complicated to implement or maintain. We didn't want to kill a feature (even though there is probably hardly a use case) without need.

About special fields: I did not yet have any better idea to place them but the general tab. But this is no permanent solution. So I decided to keep this as it is and leave it to a dedicated SpecialFields PR, because I would like to focus here on extracting the calls to JabRefPreferences out of the codebase.

NatBib style is (if i remember right) 'Lastname' or 'Lastname et al.'

@calixtus calixtus marked this pull request as ready for review May 25, 2020 10:37
@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 25, 2020
@calixtus

Copy link
Copy Markdown
Member Author

Done what I planned to do here.
@tobiasdiez do you have a suggestion for the natbib label?

@tobiasdiez

Copy link
Copy Markdown
Member

What about "Show only lastname" instead of natbib? (but this is already in abbreviations...so I'm not sure what natbib actually does ;-)).

Ok, then I would vote to remove the "Show extra columns" option and always add these fields to the dropdown. It's not hurting if there are a couple of more options to select.

I agree with the special fields, it was just an observation as you were already touching the code.

I'll review the code later....

@Siedlerchr

Copy link
Copy Markdown
Member

I fear a merge conflict in/with #6479 regarding the maintableformatter. Therefore I would propose to first merge the other PR and then this.

@calixtus

Copy link
Copy Markdown
Member Author

Agreed. I took a look at it, we definitely should merge #6479 first. Integrating the changes shouldn't be that hard. Although we worked on the same code, we were working on different aspects.

@Siedlerchr

Copy link
Copy Markdown
Member

#6479 has been merged now.

calixtus added 3 commits May 28, 2020 18:17
# Conflicts:
#	src/main/java/org/jabref/gui/maintable/BibEntryTableViewModel.java
#	src/main/java/org/jabref/gui/maintable/MainTableNameFormatter.java
@Siedlerchr Siedlerchr merged commit 41678ce into master May 28, 2020
@Siedlerchr Siedlerchr deleted the refactor_tableprefs branch May 28, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The maintable authors' column does not update on preference change

3 participants