Refactor externalprefs#6509
Merged
Merged
Conversation
Siedlerchr
approved these changes
May 22, 2020
…prefs # Conflicts: # src/main/java/org/jabref/preferences/JabRefPreferences.java # src/main/java/org/jabref/preferences/PreferencesService.java
tobiasdiez
approved these changes
May 23, 2020
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Looks good to me.
I vaguely remember that there was a reason why there was an extra dialog to specify the detailed information for an application (path + cmd args). Is this still necessary or can this be actually inlined in the preference dialog?
Member
Author
|
Only reason why I can think of is because the content depends on the application. Emacs e.g. has an additional textfield for c l arguments etc. |
Member
|
ok, if you think it would be easy to integrate, then this would be a valuable improvement. |
5 tasks
Siedlerchr
added a commit
that referenced
this pull request
May 26, 2020
* upstream/master: (76 commits) Fixes missing library properties context menu on library tab (#6508) Bump flexmark-ext-gfm-strikethrough from 0.61.30 to 0.61.32 Bump archunit-junit5-api from 0.13.1 to 0.14.1 Bump flexmark from 0.61.30 to 0.61.32 Bump flexmark-ext-gfm-tasklist from 0.61.30 to 0.61.32 Add javadoc and fix the preview update issue Refactor externalprefs (#6509) Extend the bib file for better screenshots Remove Grobid also from tests Fix help file tests Update ActionHelper.java Adjusted fix by using StateManager for clearing search bar fix checkstyle Return true in action helper if file is online link Reenable caching of gradle Refactor BibtexKeyPatternPreferences (#6489) Update CHANGELOG.md Add changelog entry and remove unnecessary code EasyBind revision part two Fix Drag and Drop on empty database ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6489
Made some minor cosmetic changes to the ExternalTab.
Everything else should be self explaining.