Skip to content

Merge identical group colors#6491

Closed
WangAooa wants to merge 14 commits into
JabRef:masterfrom
WangAooa:master
Closed

Merge identical group colors#6491
WangAooa wants to merge 14 commits into
JabRef:masterfrom
WangAooa:master

Conversation

@WangAooa

@WangAooa WangAooa commented May 18, 2020 •
edited by calixtus
Loading

Copy link
Copy Markdown
Contributor

Fixes #6175

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@WangAooa WangAooa mentioned this pull request May 18, 2020
Closed
5 tasks
@calixtus calixtus changed the title fix 6175 Merge identical group colors May 19, 2020
@calixtus

calixtus commented May 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for the update. Next time, please reuse the existing PR as otherwise we are loosing track of all the PRs. Please fix the remaining checkstyle issues, then we can review this.
Edit: On the other hand, this is already on review 😉

@calixtus calixtus marked this pull request as draft May 19, 2020 12:02
@calixtus calixtus marked this pull request as ready for review May 19, 2020 12:07
@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: changes-required Pull requests that are not yet complete labels May 19, 2020
tobiasdiez
tobiasdiez requested changes May 21, 2020
View reviewed changes

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Your solution looks good. It might be a bit more readable, however, if you instead use Stream.distinct in https://github.com/JabRef/jabref/pull/6491/files#diff-3550abce7f352ea1c73ed2c0e0e0dd37R181. Could you please try if this works indeed. I guess it would be good to add distinct also in the calculation of matchedGroupsString further below.

@WangAooa WangAooa closed this May 27, 2020
@calixtus

calixtus commented May 27, 2020

Copy link
Copy Markdown
Member

Was closing this PR intentional?

@calixtus calixtus mentioned this pull request Jun 1, 2020
Closed
5 tasks
calixtus added a commit that referenced this pull request Aug 18, 2020
@calixtus
Finished regarding comments in PR #6491
f905314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez tobiasdiez requested changes

Assignees

No one assigned

Labels

status: changes-required Pull requests that are not yet complete status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Group color, only display identical colors once

3 participants

@WangAooa @calixtus @tobiasdiez