Skip to content

Update gradle from 6.3 to 6.5.1#6431

Closed
koppor wants to merge 8 commits into
masterfrom
udpate-gradle-to-64
Closed

Update gradle from 6.3 to 6.5.1#6431
koppor wants to merge 8 commits into
masterfrom
udpate-gradle-to-64

Conversation

@koppor

@koppor koppor commented May 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

See https://docs.gradle.org/6.4/release-notes.html and https://docs.gradle.org/6.5/release-notes.html for the release notes.

Not sure how following impacts us:

With this release, Gradle supports the Java Module System with everything you need to compile and execute tests for Java modules. You can also build Javadoc and run applications.

We need to fix our build file (?)

Execution failed for task ':generateBstGrammarSource'.
 
Caused by: java.lang.IllegalStateException: The value for task ':generateBstGrammarSource' property 'mainClass' is final and cannot be changed any further.

@koppor koppor marked this pull request as draft May 6, 2020 18:54
@Siedlerchr

Siedlerchr commented May 6, 2020

Copy link
Copy Markdown
Member

https://docs.gradle.org/6.4/userguide/upgrading_version_6.html#new_properties_may_shadow_variables_in_build_scripts

@koppor

koppor commented May 6, 2020

Copy link
Copy Markdown
Member Author

The issue seems to be here:

jabref/buildSrc/src/main/groovy/org/jabref/build/antlr/AntlrTask.groovy

Line 28 in 2af41eb

main = commandLine.main

We need this special plugin as we use both ANTLR3 and ANTLR4. We cannot udpate our ANTLR3 grammar to ANTLR4. This is more than one hour effort since ANTLR changed consideradibly.

@tobiasdiez

tobiasdiez commented May 6, 2020 •
edited by koppor
Loading

Copy link
Copy Markdown
Member

According to https://docs.gradle.org/6.4/userguide/java_library_plugin.html#declaring_package_visibility_and_services

The Java module system supports additional more fine granular encapsulation concepts than Gradle itself currently does. For example, you explicitly need to declare which packages are part of your API and which are only visible inside your module. Some of these capabilities might be added to Gradle itself in future versions.

Until this is implemented, there is no real hope for us to use these new module system features of gradle.

@Siedlerchr

Siedlerchr commented May 6, 2020

Copy link
Copy Markdown
Member

Regarding the grammar task, would it be sufficient to change the variable name?
from what I understand the problem is that the variable name main has to be changed

@koppor

koppor commented May 12, 2020

Copy link
Copy Markdown
Member Author

Idea: Extend from a general gradle task and instantiate JavaExec internally (and do not inherit from it anymore)

@Siedlerchr

Siedlerchr commented May 13, 2020

Copy link
Copy Markdown
Member

I maybe found a solution, the "=" has to be changed to set.
See:
gradle/gradle#12841
And https://github.com/franzbecker/gradle-lombok/pull/77/files for an implementation

Siedlerchr added 3 commits May 16, 2020 19:35
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into udpate-gradle-to-64
8cd69cc 
* upstream/master: (50 commits)
  Keep group pane size when resizing window (#6180) (#6423)
  Changelog: Fix missing citation for biblatex-mla
  Update AUTHORS
  Check duplicate DOI (#6333)
  Fix missing citation for biblatex-mla
  Change EasyBind dependency (#6480)
  Add testing of latest dev version as mandatory
  Squashed 'src/main/resources/csl-styles/' changes from 5dad23d..586e0b8
  Fix libre office connection and other progress dialogs (#6478)
  Fix clear year and month field when converting to biblatex (#6434)
  Add truncate as a BibTex key modifier (#6427)
  Add new authors (not all - they need more work)
  Remove empty line
  Add simple Unit Tests for #6207 (#6240)
  Enforce LeftCurly rule (#6452)
  Implement task progress indicator (and dialog) in the toolbar (#6443)
  Consider empty brackets
  Changelog update
  Added a test
  Fixed brackets in regular expressions
  ...
@Siedlerchr
update to setMain
0ec7214
@Siedlerchr
setmain in configure
954b93c
@Siedlerchr

Siedlerchr commented May 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Unfortunately my fixes didn't work, they compile, but afterwards the path is not found. Fck gradle.
Edit// Maybe this helps? https://github.com/liquibase/liquibase-gradle-plugin/pull/71/files

@koppor koppor changed the title Update gradle from 6.3 to 6.4 Update gradle from 6.3 to 6.5 Jun 16, 2020
@koppor koppor changed the title Update gradle from 6.3 to 6.5 Update gradle from 6.3 to 6.5.1 Jul 20, 2020
@Siedlerchr

Siedlerchr commented Jul 20, 2020

Copy link
Copy Markdown
Member

Still errors with our plugins. My changes didn't work.

@koppor koppor closed this Jul 21, 2020
@koppor koppor deleted the udpate-gradle-to-64 branch July 21, 2020 06:28
@koppor koppor mentioned this pull request Jul 21, 2020
Closed
@Siedlerchr

Siedlerchr commented Oct 26, 2020

Copy link
Copy Markdown
Member

Still does not work with gradle 6.7 , however I noticed that they reworked the plugin:
I don't know much of this gradle stuff, but maybe this helps?

https://github.com/gradle/gradle/blob/fa4d3ad3ffd3ec3c321e5715879cecbb85a2aebd/subprojects/antlr/src/main/java/org/gradle/api/plugins/antlr/AntlrPlugin.java#L53-L57

@Siedlerchr Siedlerchr mentioned this pull request Nov 14, 2020
Merged
5 tasks
koppor pushed a commit that referenced this pull request Apr 15, 2023
Squashed 'buildres/csl/csl-styles/' changes from 41531558a8..4728902faa
09f241c 
4728902faa Create wiley-was.csl (#6283)
5853909f89 Create journal-of-human-nutrition-and-dietetics.csl (#6311)
286a3606c1 Create stanovnistvo.csl (#6431)
22a7139dc5 Update zitierguide-leitfaden-zum-fachgerechten-zitieren-in-rechtswiss… (#6489)
e51e9363ee Update netherlands-journal-of-geosciences-geologie-en-mijnbouw.csl (#6493)
4e1a69231c Add Bristol UP dependents (auto-generated) (#6494)
c9021437a4 Create microbiome-research-reports.csl (#6371)
f71e516dda Update harvard-anglia-ruskin-university.csl (#6365)
c187663e75 Create publicatiewijzer.csl (#6316)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 4728902faa1ef43c0d89366c77b7ea8f46c6730f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koppor @Siedlerchr @tobiasdiez