RIS import takes the wrong date and duplicates abstract#6272
Merged
Conversation
Siedlerchr
approved these changes
Apr 12, 2020
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks for contributing looks good to me!
tobiasdiez
requested changes
Apr 13, 2020
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
The change looks good to. Thanks! Could you please add a test that makes sure the example provided in #6065 is now indeed properly imported.
For this create the ris file and the corresponding bib file here: https://github.com/JabRef/jabref/tree/master/src/test/resources/org/jabref/logic/importer/fileformat (they are then automatically picked up).
Contributor
Author
|
OK, will do. |
Member
|
Thanks! |
Siedlerchr
added a commit
that referenced
this pull request
Apr 17, 2020
…ionCaseInsensitive * upstream/master: (25 commits) ActionHelper to test for present file (#6151) Reduce memory footprint (#6298) Add missing abbreviated journal names (#6292) fix l10n again fix checkstyle fix l10n Try to minimize CodeCov "wrong metrics" Showing correct icon on main table linked files column (#6264) Fix labels for outdated dependency issue Change one more line Squashed 'src/main/resources/csl-styles/' changes from c31d9ca..c1793d2 Resolve unit test from failing Add one more change Fix errors RIS import takes the wrong date and duplicates abstract (#6272) Update EntryTypeView.java Change to the old school format Fix XmpExporterTest (#6289) Add checkstyle screenshot (and lint guidelines-...md) Squashed 'src/main/resources/csl-styles/' changes from db54e56..c31d9ca ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6065
See lines 207-220 of
RisImporter.java. It works fine and importing publication date as expected. Tested on file from @crystalfp (see file, attached to issue).Kind regards,
Gennadiy