Fix inspire fetcher#6258
Merged
Merged
Conversation
Use application/x-bibtex header Fixes #6229
tobiasdiez
requested changes
Apr 7, 2020
| //uriBuilder.addParameter("jrec", "1"); // Start index (not needed at the moment) | ||
| uriBuilder.addParameter("rg", "100"); // Should return up to 100 items (instead of default 25) | ||
| uriBuilder.addParameter("of", "hx"); // BibTeX format | ||
| uriBuilder.addParameter("q", query); // Query |
Member
There was a problem hiding this comment.
there is no paging support (start + size) for the new interface?
Member
Author
There was a problem hiding this comment.
The json api has support for it, but when calling with the bibtex header not.
There was a problem hiding this comment.
On my end &size=10&page=2 seems to works fine as of today, not sure about a week ago.
Member
Author
There was a problem hiding this comment.
Indeed, this seems to work. I will create a follow up PR
| public class INSPIREFetcher implements SearchBasedParserFetcher { | ||
|
|
||
| private static final String INSPIRE_HOST = "https://inspirehep.net/search"; | ||
| private static final String INSPIRE_HOST = "https://inspirehep.net/api/literature/"; |
Member
There was a problem hiding this comment.
Could you please include the link to the documentation of the new api as well.
Member
Author
There was a problem hiding this comment.
There is not yet any documentation avaiable. I contacted INSPIRE hep team.
* upstream/master: (23 commits) Bump junit-vintage-engine from 5.6.1 to 5.6.2 (#6276) Number of items found in ImportEntriesDialog (#6248) Fix dependency label Bump flexmark-ext-gfm-strikethrough from 0.61.0 to 0.61.6 (#6273) Bump unirest-java from 3.7.01 to 3.7.02 (#6275) Bump junit-platform-launcher from 1.6.1 to 1.6.2 (#6279) Bump flexmark-ext-gfm-tasklist from 0.61.0 to 0.61.6 (#6278) Bump junit-jupiter from 5.6.1 to 5.6.2 (#6274) Bump flexmark from 0.61.0 to 0.61.6 (#6280) Bump classgraph from 4.8.68 to 4.8.69 (#6277) Bump org.beryx.jlink from 2.17.4 to 2.17.5 (#6281) Improve performance (#6270) Improve calculation of matched entries upon change (#6268) Fix sort by priority (#6222) (#6265) Squashed 'src/main/resources/csl-styles/' changes from 88726cb..db54e56 Use https everywhere Entry editor: Add more tooltips and wrap tooltips if necessary (#6239) JDK14 switch - and checkstyle skipping (#6250) Bump postgresql from 42.2.11 to 42.2.12 (#6254) Bump unirest-java from 3.7.00 to 3.7.01 (#6253) ...
revert not related changes
koppor
approved these changes
Apr 14, 2020
koppor
pushed a commit
that referenced
this pull request
Dec 1, 2022
bef74ed Create conservation-science-and-practice.csl (#6258) 9fb7eb7 Bug fixes triangle.csl (#6251) e6112ba Update ucl-university-college-apa.csl (#6250) 6dcba3a Update engineering-technology-and-applied-science-research.csl (#6247) 00fe4a2 Create constructivist-foundations.csl (#6243) 03ad71b Create les-mondes-du-travail.csl (#6234) a2bce86 Corrections based on author instructions (#6306) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: bef74ed
koppor
pushed a commit
that referenced
this pull request
Dec 15, 2022
f6c778e Update emerald-harvard.csl (#6335) d6c6a16 Fix Brazilian quotes on chicago-author-date.csl (#6317) a1549b6 Update medizinische-hochschule-hannover.csl (#6330) da88073 Update journal-of-the-american-college-of-cardiology.csl (#6334) a520d8e Bump nokogiri from 1.13.9 to 1.13.10 (#6333) ba54b44 Update royal-society-of-chemistry.csl (#6328) 1378ba7 LUSEM: Remove full stop (#6332) 9e3cf89 Create interpreting.csl (#6254) bef74ed Create conservation-science-and-practice.csl (#6258) 9fb7eb7 Bug fixes triangle.csl (#6251) e6112ba Update ucl-university-college-apa.csl (#6250) 6dcba3a Update engineering-technology-and-applied-science-research.csl (#6247) 00fe4a2 Create constructivist-foundations.csl (#6243) 03ad71b Create les-mondes-du-travail.csl (#6234) a2bce86 Corrections based on author instructions (#6306) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: f6c778e
koppor
pushed a commit
that referenced
this pull request
Dec 17, 2022
84dba23 Update international-union-of-crystallography.csl (#6279) 13dd9e8 Update zeitschrift-fur-deutsche-philologie.csl (#6340) d95b652 Create cahiers-mondes-anciens.csl (#6203) ded567c Create rassegna-degli-archivi-di-stato-bibliografia-generale.csl (#6275) 124777a Create scientific-online-letters-on-the-atmosphere.csl (#6261) 3c276e7 Create american-medical-association-no-url-alphabetical.csl (#6252) 595ad95 Bump mathieudutour/github-tag-action from 6.0 to 6.1 (#6287) 7008128 Create cambridge-a (#6336) 17e930c Update norsk-apa-manual-note.csl (#6338) b360859 Update norsk-apa-manual.csl (#6337) f6c778e Update emerald-harvard.csl (#6335) d6c6a16 Fix Brazilian quotes on chicago-author-date.csl (#6317) a1549b6 Update medizinische-hochschule-hannover.csl (#6330) da88073 Update journal-of-the-american-college-of-cardiology.csl (#6334) a520d8e Bump nokogiri from 1.13.9 to 1.13.10 (#6333) ba54b44 Update royal-society-of-chemistry.csl (#6328) 1378ba7 LUSEM: Remove full stop (#6332) 9e3cf89 Create interpreting.csl (#6254) bef74ed Create conservation-science-and-practice.csl (#6258) 9fb7eb7 Bug fixes triangle.csl (#6251) e6112ba Update ucl-university-college-apa.csl (#6250) 6dcba3a Update engineering-technology-and-applied-science-research.csl (#6247) 00fe4a2 Create constructivist-foundations.csl (#6243) 03ad71b Create les-mondes-du-travail.csl (#6234) a2bce86 Corrections based on author instructions (#6306) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 84dba23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use application/x-bibtex header
Fixes #6229