[WIP] Use JDK14 switch expressions - checkstyle needs to be updated#6202
Closed
koppor wants to merge 3 commits into
Closed
[WIP] Use JDK14 switch expressions - checkstyle needs to be updated#6202koppor wants to merge 3 commits into
koppor wants to merge 3 commits into
Conversation
Siedlerchr
approved these changes
Mar 29, 2020
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Next time please consider fixing an issue instead of just code refactorings.
Member
Author
|
It was a "drive-by-shooting" while I was working on something else. Further, the wish was to keep pull requests small to easy reviewing (@stefan-kolb). Therefore, I spent effort to separate the easy-to-review things from another PR (not yet opened). This helps
|
Member
Author
|
Blocked by checkstyle/checkstyle#7992. |
tobiasdiez
requested changes
Mar 30, 2020
|
|
||
| for (i = 0; i < (x - 2); i++) { | ||
| sb.append(authors[i]).append("; "); | ||
| case 1 -> s = authors[0]; // just no action |
Member
There was a problem hiding this comment.
why not use the full power of the switch expressions and write String s = switch (...) ?
Member
Author
There was a problem hiding this comment.
IntelliJ did not recommend it ^^. Just submit an update here :)
Member
Author
|
ETA for the fix September 2020. |
This partially reverts commit 6a14740.
Member
Author
|
Closed to reduce the noise. |
koppor
pushed a commit
that referenced
this pull request
Oct 15, 2022
4eee79a Fix director not showing in MHRAs (#6271) 20c4b5e Update the-journal-of-pain.csl (#6202) 6ba269f Added missing book volume in short-title-note (#6262) 1a11c0f Update harvard-stellenbosch-university.csl (#6256) 6b598e7 Update karstenia.csl (#6242) 38bc5fe APA: Swap priority for periodical page and number (#6255) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 4eee79a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I applied some IntelliJ suggestions - also includes using JDK14 switch expressions. This causes issues at checkstyle.