Fix action helper by stefan-kolb · Pull Request #6122 · JabRef/jabref

stefan-kolb · 2020-03-14T14:43:12Z

only reason here that I can think of is that the selection (maybe only on Linux) makes problems and returns an empty List

The only reason I can think of might be caused by the following code snippet:

    public static BooleanExpression isAnyFieldSetForSelectedEntry(List<Field> fields, StateManager stateManager) {
        BibEntry entry = stateManager.getSelectedEntries().get(0);
        return Bindings.createBooleanBinding(
                () -> entry.getFields().stream().anyMatch(fields::contains),
                entry.getFieldsObservable(),
                stateManager.getSelectedEntries());
    }

BibEntry entry = stateManager.getSelectedEntries().get(0);

Also I do not know how to trigger this method without an entry selected it might still be an empty list.
At least this is what the error log says. So we can only get the entry when it exists.

Fixes #6085.

Found another bug:
How to reproduce:

select two entries (one with an attached file one without) First needs to be the one with a file!
select open folder in context menu
exception occurs for selected entry without attached file

Related #6085

I is hard to test this, as normally a selection should be given when the method is triggered. Fixes #6085

Co-Authored-By: Tobias Diez <tobiasdiez@gmx.de>

stefan-kolb · 2020-03-14T15:53:39Z

Thanks @tobiasdiez , that looks good!

calixtus · 2020-03-14T16:14:26Z

Does this also cover the case that an entry stays selected while a field is emptied in the entry editor?

calixtus · 2020-03-14T16:18:00Z

+            } else {
+                return entry.get().getFields().stream().anyMatch(fields::contains);
+            }
+        }, selectedEntries);


I'm missing entry.getFieldsObserable() here. Is this intended?

Good catch. This is a problem - it might not be available (that's why I need the complex code above). I'm not sure what side effects this might have, I need you guys' expertise here.

Not sure but maybe the following works:

EasyBind.monadic(entry) .flatMap(BibEntry:getFieldsObservable) .map(entryFields -> entryFields.anyMatch(...))

When does this situation occur? I.e. the fields of the entry change dynamically?

This binding should update in the case when the selected entry changes as well as when the fields of the currently selected entry change

stefan-kolb · 2020-03-14T16:27:49Z

Does this also cover the case that an entry stays selected while a field is emptied in the entry editor?

We need to test this. Probably not right now as the binding to getFields() is missing like you already mentioned.

tobiasdiez · 2020-04-10T15:04:28Z

What's the status here?

stefan-kolb · 2020-04-10T15:37:34Z

I have no correct solution for both cases as discussed above. however, I'm not sure if the field change? can actually occur.

tobiasdiez · 2020-04-14T06:43:53Z

Maybe with

jabref/src/main/java/org/jabref/gui/StateManager.java

Line 39 in fb2a6d7

    
           private final ObservableList<BibEntry> selectedEntries = FXCollections.observableArrayList();

extractor.

Siedlerchr · 2020-05-01T17:02:36Z

I can reproduce the error always if I close all databases and then try to click on the View Menu. Also on Windows

tobiasdiez · 2020-05-03T11:41:31Z

I found a way to fix the binding. It should work now.

Siedlerchr

Does this also work for the view menu with no database open?

* upstream/master: Fix action helper (#6122)

7bde3e4 Add style for the Geographical Analysis journal (#6145) 6fa1551 Create taylor-and-francis-chicago-b-author-date.csl (#6232) eba2e8c Create taylor-and-francis-ama.csl (#6221) dda9d57 ACS, AMA, Vancouver: Remove hardcoded space after `citation-number` (#6248) 8f5fe92 GitHub Workflows security hardening (#6246) 284bc10 Create angiology.csl (#6122) eb141cc Update society-of-biblical-literature-fullnote-bibliography.csl (#6157) dddb459 Rewrite law-citation-manual.csl (#6171) (#6171) b975c96 Update Cell to numeric-superscript style (#6245) 3a41b08 Create isara-iso-690.csl (#6201) 5a128fe Create Biomembranes.csl (#6200) da2e0c0 Capitalize-first short titles for legislation ("Statute"). (#6241) af7f08d Create proceedings-of-the-estonian-academy-of-sciences-author-date.csl (#6209) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 7bde3e4

stefan-kolb added 2 commits March 14, 2020 15:29

fix: not every selected entry will have a file

383391d

Related #6085

fix: this will probably fix missing selection information on Linux

e6e27a9

I is hard to test this, as normally a selection should be given when the method is triggered. Fixes #6085

stefan-kolb requested review from Siedlerchr, calixtus and tobiasdiez March 14, 2020 14:43

Siedlerchr approved these changes Mar 14, 2020

View reviewed changes

tobiasdiez reviewed Mar 14, 2020

View reviewed changes

Comment thread src/main/java/org/jabref/gui/actions/ActionHelper.java Outdated

Update src/main/java/org/jabref/gui/actions/ActionHelper.java

1bd2770

Co-Authored-By: Tobias Diez <tobiasdiez@gmx.de>

stefan-kolb requested a review from tobiasdiez March 14, 2020 15:57

Update ActionHelper.java

058c725

stefan-kolb force-pushed the fix-action-helper branch from c3df843 to 058c725 Compare March 14, 2020 16:06

calixtus reviewed Mar 14, 2020

View reviewed changes

JabRef deleted a comment from codecov Bot Mar 17, 2020

Merge branch 'master' into fix-action-helper

9f3cf81

JabRef deleted a comment from codecov Bot Mar 29, 2020

tobiasdiez self-assigned this Apr 14, 2020

tobiasdiez marked this pull request as draft April 17, 2020 15:59

calixtus mentioned this pull request Apr 22, 2020

Exception when trying to use context menu #6085

Closed

Siedlerchr mentioned this pull request May 1, 2020

Uncaught exception when selecting "View" menu #6385

Closed

Fix binding

a2aa16f

tobiasdiez marked this pull request as ready for review May 3, 2020 11:41

tobiasdiez approved these changes May 3, 2020

View reviewed changes

tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 3, 2020

Add changelog entry

e032d9d

Siedlerchr approved these changes May 3, 2020

View reviewed changes

Siedlerchr merged commit b472942 into master May 3, 2020

Siedlerchr deleted the fix-action-helper branch May 3, 2020 13:20

Siedlerchr added a commit that referenced this pull request Jul 1, 2020

Merge remote-tracking branch 'upstream/master' into allowReordering

dcbe938

* upstream/master: Fix action helper (#6122)

Uh oh!

Conversation

stefan-kolb commented Mar 14, 2020 • edited by tobiasdiez Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

stefan-kolb commented Mar 14, 2020

Uh oh!

calixtus commented Mar 14, 2020

Uh oh!

calixtus Mar 14, 2020

Choose a reason for hiding this comment

Uh oh!

stefan-kolb Mar 14, 2020

Choose a reason for hiding this comment

Uh oh!

tobiasdiez Mar 14, 2020

Choose a reason for hiding this comment

Uh oh!

stefan-kolb Mar 15, 2020

Choose a reason for hiding this comment

Uh oh!

tobiasdiez Mar 15, 2020

Choose a reason for hiding this comment

Uh oh!

stefan-kolb commented Mar 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasdiez commented Apr 10, 2020

Uh oh!

stefan-kolb commented Apr 10, 2020

Uh oh!

tobiasdiez commented Apr 14, 2020

Uh oh!

Siedlerchr commented May 1, 2020

Uh oh!

tobiasdiez commented May 3, 2020

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stefan-kolb commented Mar 14, 2020 •

edited by tobiasdiez

Loading

stefan-kolb commented Mar 14, 2020 •

edited

Loading