Use github action to publish snap by LyzardKing · Pull Request #6063 · JabRef/jabref

LyzardKing · 2020-03-04T15:43:28Z

Use github actions to publish,
to try and reduce the upload time

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for bigger UI changes)
Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

LyzardKing · 2020-03-04T15:44:59Z

@Siedlerchr The upload is taking a lot longer than it should..
Maybe the "semi-official" github action can help..

Siedlerchr · 2020-03-04T16:21:28Z

Please note that the snap craft upload is currently only for master branch, at least I saw a filter

koppor · 2020-03-04T16:36:10Z

I don't know which action @Siedlerchr is referring to. Maybe you can add a link?

@LyzardKing I would ❤️ if you added an ADR for the choice of the action. Just place it at https://github.com/JabRef/jabref/tree/master/docs/adr.

I found following action as alternative - can just be added to the list of options ;) --> https://github.com/marketplace/actions/snapcraft-action

LyzardKing · 2020-03-04T16:58:55Z

The GitHub actions are from https://forum.snapcraft.io/t/call-for-testing-github-action-for-snapcraft/14930
They are developed from someone in the snapcraft team.
At the moment we're already using his build action.
This pr adds the upload action

Siedlerchr · 2020-03-04T21:33:43Z

@@ -117,11 +117,11 @@ jobs:
      - name: Build snap (1) Setup snapcraft


I think it would make sense to run this in parallel as it's own job?

Currently does not work at all: https://github.com/JabRef/jabref/actions/runs/49715346

cannot read snap file "build/distribution/jabref*.snap"

Trying to debug.

It's also very difficult to do it in parallel in a separate workflow (which is not what you meant, right?). IMHO it depends on the steps above (including jpackage, ...). Thus, we would need to duplicate 100 SLOC of the build file.

We could work with different jobs in the same build file. Then, we would need to introduce uploading the build directory (more?) to GitHub as data passing between jobs can only be done that way. This is not comfortable (we have to be sure that we don't forget something)

Cannot read is because the * is not expanded. Fixed it in cd70746

LyzardKing · 2020-03-04T22:15:58Z

Thanks both for looking at this..
I didn't have much time to do this while on a train with no stable internet connection.
EDIT I'll look at adding the markdown file with the selected solution tomorrow morning.

Siedlerchr · 2020-03-04T22:21:30Z

Both master and the master-release fail at some point in the snapcraft upload
##[error]The operation was canceled.
@LyzardKing Btw, we still also have the snapcraft.yml , so I could try to trigger a rebuild there at the official snapcraft ci if that is possible with our infrastructure

LyzardKing · 2020-03-05T08:06:51Z

@koppor I changed the snap to use https://builds.jabref.org/master/JabRef-5.0-portable_linux.tar.gz instead of the build artifact (you can see the comment in the snapcraft.yaml) to test it..
If we keep the source as https://builds.jabref.org/master/JabRef-5.0-portable_linux.tar.gz it might be easier to add it to the snapcraft CI and use it there (it should rebuild every time a new tar.gz is uploaded.
If we want to use the github action instead is it possible to make the snap action run after the artifact build action?

LyzardKing · 2020-03-05T20:01:45Z

@Siedlerchr I think it might be easier if we try and run the snapcraft CI..
The snapcraft as it is now (with the full url as source) will work with that.
If it works then we can remove the snap part in the github actions, it seems to complicated to get working properly..

Siedlerchr · 2020-03-05T20:07:24Z

I triggered a new build

Siedlerchr · 2020-03-05T21:03:01Z

@LyzardKing Snapcraft runs but shows this weird message regarding license:

https://build.snapcraft.io/user/JabRef/jabref/858770

Could not find '/snap/core/current/usr/bin/snap', validation of the license string will only take place once pushed to the store.
Snapping 'jabref' ...

Snapped jabref_5.0.30532_amd64.snap
Revoking proxy token...
RUN: /usr/share/launchpad-buildd/bin/in-target scan-for-processes --backend=lxd --series=bionic --arch=amd64 SNAPBUILD-858770
Scanning for processes to kill in build SNAPBUILD-858770

LyzardKing · 2020-03-07T18:46:11Z

@Siedlerchr The review is manual and will need roughly two weeks.
https://forum.snapcraft.io/t/system-files-under-mozilla-native-messaging-hosts/13627/41

Siedlerchr · 2020-03-07T18:50:36Z

Ah okay thanks for checking that!

koppor · 2020-03-09T05:38:48Z

@LyzardKing The "manual review" is for each published version or a general "OK" for this and all upcoming next versions?

LyzardKing · 2020-03-09T06:16:17Z

As I understand it the approval should be done once for be permissions we asked.
So unless we change the permissions it shouldn't be done any more

39fede5 Update associacao-brasileira-de-normas-tecnicas.csl (#6138) fde7695 Include chapter title (#6140) 1e3d8b4 Update n.d. abbreivation for DGP style (#6136) ebb728b suffix '.' after first group; changed e-mail (#6135) eed4f07 Update and rename sciences-po-ecole-doctorale-note-french.csl to scie… (#6127) f194647 Delete TU Dresden Medizin as requested by library (#6131) d8423d8 Create entomological-review.csl (#6120) 064a394 Create australasian-journal-of-philosophy.csl (#6063) a998ded Add composer.json (#5668) 37083c9 Update copernicus-publications.csl (#6062) 694c97b Create chaucer review (#6061) 625a424 Create haffner-style-manual.csl (#6054) 8b7224b make annals-of-allergy-asthma-and-immunology independent (#6041) 710748c Create university-of-pretoria-harvard-theology-religion.csl (#6106) d16dffd Create health-physics.csl (#6040) ca9e184 Update style-manual-australian-government.csl (#6119) e412277 Create chemical-engineering-technology.csl (#6039) bebdb48 Create bibliothek-forschung-und-praxis.csl (#6038) 29e49cd Update nature.csl (#6117) 891897d fix short title for SBL (#6118) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 39fede5

c750b6e APA: Put conditional event-title logic in a macro (#6161) a87414f Remove month from association-for-compuational-linguistics.csl (#6158) 6153db0 Remove issue numbers from BJOC style (#6155) e231ea3 Bug fix for `event` regression (#6154) 0dab651 Add event-title to other APA styles (#6153) 698cf1c APA: `event-title` and conditional `event` (#6152) 58d3f8f Update vancouver-author-date.csl (#6148) f1638a9 add substitute to Vancouver author date (#6147) 39fede5 Update associacao-brasileira-de-normas-tecnicas.csl (#6138) fde7695 Include chapter title (#6140) 1e3d8b4 Update n.d. abbreivation for DGP style (#6136) ebb728b suffix '.' after first group; changed e-mail (#6135) eed4f07 Update and rename sciences-po-ecole-doctorale-note-french.csl to scie… (#6127) f194647 Delete TU Dresden Medizin as requested by library (#6131) d8423d8 Create entomological-review.csl (#6120) 064a394 Create australasian-journal-of-philosophy.csl (#6063) a998ded Add composer.json (#5668) 37083c9 Update copernicus-publications.csl (#6062) 694c97b Create chaucer review (#6061) 625a424 Create haffner-style-manual.csl (#6054) 8b7224b make annals-of-allergy-asthma-and-immunology independent (#6041) 710748c Create university-of-pretoria-harvard-theology-religion.csl (#6106) d16dffd Create health-physics.csl (#6040) ca9e184 Update style-manual-australian-government.csl (#6119) e412277 Create chemical-engineering-technology.csl (#6039) bebdb48 Create bibliothek-forschung-und-praxis.csl (#6038) 29e49cd Update nature.csl (#6117) 891897d fix short title for SBL (#6118) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: c750b6e

Use github action to publish snap

8fdfcfa

JabRef deleted a comment from codecov Bot Mar 4, 2020

koppor mentioned this pull request Mar 4, 2020

Try to update GitVersion action from v0.3 to v0.9 #6061

Merged

koppor force-pushed the master branch from 12e1bba to 6e01745 Compare March 4, 2020 16:58

koppor force-pushed the master branch 2 times, most recently from b8ef7b7 to 21c6e5e Compare March 4, 2020 17:02

Build snap only for master branch

1a7a4df

JabRef deleted a comment from codecov Bot Mar 4, 2020

Siedlerchr reviewed Mar 4, 2020

View reviewed changes

koppor merged commit 29ed8fe into master Mar 5, 2020

koppor deleted the snapcraft-publish-action branch March 5, 2020 05:09

		@@ -117,11 +117,11 @@ jobs:
		- name: Build snap (1) Setup snapcraft

Uh oh!

Conversation

LyzardKing commented Mar 4, 2020

Uh oh!

LyzardKing commented Mar 4, 2020

Uh oh!

Siedlerchr commented Mar 4, 2020

Uh oh!

koppor commented Mar 4, 2020

Uh oh!

LyzardKing commented Mar 4, 2020

Uh oh!

Siedlerchr Mar 4, 2020

Choose a reason for hiding this comment

Uh oh!

koppor Mar 4, 2020

Choose a reason for hiding this comment

Uh oh!

koppor Mar 4, 2020

Choose a reason for hiding this comment

Uh oh!

koppor Mar 4, 2020

Choose a reason for hiding this comment

Uh oh!

LyzardKing commented Mar 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Mar 4, 2020

Uh oh!

LyzardKing commented Mar 5, 2020

Uh oh!

LyzardKing commented Mar 5, 2020

Uh oh!

Siedlerchr commented Mar 5, 2020

Uh oh!

Siedlerchr commented Mar 5, 2020

Uh oh!

LyzardKing commented Mar 7, 2020

Uh oh!

Siedlerchr commented Mar 7, 2020

Uh oh!

koppor commented Mar 9, 2020

Uh oh!

LyzardKing commented Mar 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LyzardKing commented Mar 4, 2020 •

edited

Loading