Set BibEntry to "changed" state before setting a new entry type#5966
Merged
Conversation
3414274 to
d08b1f8
Compare
Member
|
Cool, you found the problem. Thanks! LGTM |
calixtus
approved these changes
Feb 20, 2020
tobiasdiez
requested changes
Feb 20, 2020
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Nice! That also explains why the error only occurs the first time.
Could you please add a changelog entry, then we can merge!
Member
|
Thanks again for your contribution! 👍 |
Siedlerchr
added a commit
that referenced
this pull request
Mar 6, 2020
* upstream/master: (21 commits) Update module description (#5999) New Crowdin translations (#5990) Fix NPE in OpenAccessDoi (#5994) Move generate BibTeX keys to Edit menu (#5987) Fixed display of groups and links column in MainTable (#5985) Fixed loosing group if the most bottom one in list is dragged on itself (#5983) Dividers (#5975) Add initial section on code quality (#5991) Create .sonarcloud.properties Add new IntelliJ video tutorial to docs. (#5984) Fix checkstyle Optimize stream() code Use application/x-bibtex for Grobid instance New Crowdin translations (#5971) Set BibEntry to "changed" state before setting a new entry type (#5966) Rework tools menu (#5979) Help menu (#5976) Fixed formatting Refactored subtile changes to optics of library properties (#5969) Change grobid URL to jabref subdomain (#5972) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5905
The issue happens because changed property in BibEntry is set after updating entry type, so property listeners get entry object with new entry type but changed value set to false. Because of that wrong bibtex code is generated by:
entry.typeProperty().addListener(listener -> updateCodeArea());(SourceTab.java).