Skip to content

Try to fix linux pdf opening again#5945

Merged
Siedlerchr merged 6 commits into
masterfrom
linuxOutputstream
Feb 20, 2020
Merged

Try to fix linux pdf opening again#5945
Siedlerchr merged 6 commits into
masterfrom
linuxOutputstream

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Feb 13, 2020

Copy link
Copy Markdown
Member

Fixes #5942 and fixes probably #5882

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

Comment thread src/main/java/org/jabref/gui/desktop/os/Linux.java Outdated
@Siedlerchr

Copy link
Copy Markdown
Member Author

Could you please try again with the newest version from this branch?
I forgot one method.

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides BufferedReader closing "OK". Maybe, go ahead with that and then switch to ProcessBuilder in a follow-up PR? 😇

Comment thread src/main/java/org/jabref/gui/util/StreamGobbler.java Outdated
Comment thread src/main/java/org/jabref/gui/util/StreamGobbler.java Outdated
* upstream/master:
  followup fix
  Fixfetcher (#5948)
  Bump byte-buddy-parent from 1.10.7 to 1.10.8 (#5952)
  Added MenuButtons to IntegrityCheckDialog (#5955)
  Reimplement custom entry types dialog (#5799)
  Bump unirest-java from 3.4.03 to 3.5.00 (#5953)
  MySQL: Allow public key retrieval (#5909)
  Restructure and improve docs for setting up IntelliJ (#5960)
  Change syntax for Oracle multi-row insert SQL statement (#5837)
  Bump classgraph from 4.8.62 to 4.8.64 (#5954)
  Squashed 'src/main/resources/csl-styles/' changes from c531528..9e81857
  Fix not escaping special characters in search pattern (#5938)
@Siedlerchr Siedlerchr merged commit 5369b3b into master Feb 20, 2020
@Siedlerchr Siedlerchr deleted the linuxOutputstream branch February 20, 2020 07:32
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
* upstream/master:
  Try to fix linux pdf opening again (#5945)
  [WIP] Initial work on DBMSProcessor batch entry insertion into ENTRY table (#5814)
  followup fix
  Fixfetcher (#5948)
  Bump byte-buddy-parent from 1.10.7 to 1.10.8 (#5952)
  Added MenuButtons to IntegrityCheckDialog (#5955)
  Reimplement custom entry types dialog (#5799)
  Bump unirest-java from 3.4.03 to 3.5.00 (#5953)
  MySQL: Allow public key retrieval (#5909)
  Restructure and improve docs for setting up IntelliJ (#5960)
  Change syntax for Oracle multi-row insert SQL statement (#5837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening a PDF blocks JabRef (under Ubuntu/Linux)

3 participants