Skip to content

Fix Springer fetcher tests#5773

Merged
Siedlerchr merged 1 commit into
masterfrom
fix-springer
Dec 20, 2019
Merged

Fix Springer fetcher tests#5773
Siedlerchr merged 1 commit into
masterfrom
fix-springer

Conversation

@koppor

@koppor koppor commented Dec 20, 2019

Copy link
Copy Markdown
Member

Follow-up to https://github.com/JabRef/jabref/pull/5715/files.

In case the key does not work, a 403 Forbidden was returned and getBody() returned null. Therefore the check.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 20, 2019
@koppor koppor mentioned this pull request Dec 20, 2019
@Siedlerchr Siedlerchr merged commit c19feb1 into master Dec 20, 2019
@Siedlerchr Siedlerchr deleted the fix-springer branch December 20, 2019 21:18
@tobiasdiez

Copy link
Copy Markdown
Member

Can you please also add a Logger.error in case the body is null. Otherwise the user is never informed that something went wrong...

Siedlerchr added a commit that referenced this pull request Dec 23, 2019
* upstream/master:
  Fixes StringIndexOutOfBoundsException when cutting text (#5776)
  Bump org.beryx.jlink from 2.16.4 to 2.17.0 (#5782)
  Bump byte-buddy-parent from 1.10.5 to 1.10.6 (#5783)
  Fix line endings.
  Try to use implicit shell to enable variable correctly be set
  Fix branch name detection
  Update script to absolute path and new username
  Revert "Disable non-working cleanup_pr workflow"
  Switch to rsync (#5778)
  Fix Medline tests (#5774)
  Normalize line ending in test file (#5775)
  Fix Springer fetcher tests (#5773)
  Fix code style (#5772)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants