Fix multiple entries allowed in crossref (issue #5284)#5724
Merged
Conversation
add an attribute in tagbar to allow or not multiple entries
Fixed issue JabRef#5284 where multiple entries were allowed in crossref field, whereas only one should be allowed. JabRef#5284
tobiasdiez
requested changes
Dec 11, 2019
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks for your PR! The code looks good to me. I've only a few minor remarks, mostly concerning the code style. To fix this, it should suffice to import JabRef's Intellj code style and reformat the changed files.
Reformat code according to Jabref code style, simplify some conditions.
koppor
requested changes
Dec 13, 2019
koppor
left a comment
Member
There was a problem hiding this comment.
Thank you for working on this. I also have some code style comments.
former "isMultiple" was replaced by a use of FielProperty.Multiple_entry_link. Co-authored-by: Julien Bénard Co-authored-by: Lucas Beretti Co-authored-by: Venceslas Roullier
tobiasdiez
approved these changes
Dec 13, 2019
Replaced the boolean attribute in TagBar with a Set of properties Co-authored-by: Julien Bénard Co-authored-by: Lucas Beretti Co-authored-by: Venceslas Roullier
koppor
reviewed
Dec 15, 2019
| this.viewModel = new LinkedEntriesEditorViewModel(field, suggestionProvider, databaseContext, fieldCheckers); | ||
|
|
||
| ViewLoader.view(this) | ||
| .root(this) |
Member
There was a problem hiding this comment.
I think, this indent change is an Eclipse vs. IntelliJ-thing. I won't nitpick here. Next time, please only commit code changes, not just reformat changes.
Member
|
I merge even though the Co-authored-by-STrings are not correct Source from https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors.
|
Member
|
For follow-up: Please ensure that "checkstyle" runs through. There was a wrong import order. @Julien29121998 Did you configure your IDE correctly? |
Member
|
Nevertheless, thank you for putting effort into this. Looking forward to more contributions! |
Siedlerchr
added a commit
that referenced
this pull request
Dec 20, 2019
# By Tobias Diez (11) and others # Via GitHub (1) and Tobias Diez (1) * upstream/master: (29 commits) Improve things arround change detection (#5770) Revert "Update to most recent journal abbreviation list" (#5769) Various fixes to the dark theme (#5764) Bump mockito-core from 3.2.0 to 3.2.4 (#5760) Bump classgraph from 4.8.58 to 4.8.59 (#5761) Improve dependency update rules Update jpackage to build 27 (#5758) Persistent column sortorder (#5730) Fix medline fetcher/importer when using installer (#5752) New Crowdin translations (#5751) Bump byte-buddy-parent from 1.10.4 to 1.10.5 (#5750) Fix checkstyle Fix filename Update to most recent journal abbreviation list Remove obsolete string Revert "Switch back to development" Switch back to development Next development cycle Release 5.0-beta (#5684) Fix multiple entries allowed in crossref (issue #5284) (#5724) ... # Conflicts: # src/main/java/org/jabref/gui/collab/ChangeDisplayDialog.java # src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #5284 where multiple entries were allowed in crossref field, whereas only one should be allowed. #5284