When using the builder of BibEntry, the entry should not be mod…#5635
Merged
Conversation
Siedlerchr
requested changes
Nov 18, 2019
tobiasdiez
approved these changes
Nov 18, 2019
28cd410 to
c499daf
Compare
- Ensure that `BibEntry#withField` keeps `hasChanged() == false` - Refine comment and add empty lines in BibDatabase.java - Fix semantics of variable in SaveDatabaseActionTest (it really points to a file, not to a directory)
c499daf to
406dc4e
Compare
koppor
pushed a commit
that referenced
this pull request
Oct 1, 2021
3b00357 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5639) fcf6625 updated styles (#5638) 0df0633 Update universite-du-quebec-a-montreal-etudes-litteraires-et-semiolog… (#5614) eaddf8e Human Molecular Genetics (#5635) 0afd7fb Update harvard-cardiff-university.csl (#5623) f424672 Switch ISQ to Chicago author-date ccb7184 Update chicago-author-date.csl (#5605) a408957 SBL: implementation of book reviews (#5613) fbbe7b3 Update harvard-swinburne-university-of-technology.csl to meet published spec (#5627) 8d7a0d8 Add UNESCO IIEP style (#5631) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 3b00357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor code quality things.
BibEntry#withFieldkeepshasChanged() == false