Remove BindingsHelper for UI in MainTableDataModel#5057
Closed
Siedlerchr wants to merge 1 commit into
Closed
Conversation
tobiasdiez
reviewed
Jun 15, 2019
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
The forUI call is needed for cleanups that run in the background thread like the rename files option. I think we cannot simply remove it.
Member
Author
|
Yeah you are right. Just ran into the issue. I think in the long term we need to redefine our architecture so that we only access BibEntry from the fx threads |
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 1, 2020
5c376b8 Create karlstad-universitet-kau-harvard-swedish.csl (#5083) 6a62c24 Create ucl-institute-of-education-harvard.csl (#5084) 4d1bbb0 Update ferdinand-porsche-fern-fachhochschule.csl (#5073) 3a9f494 Update cureus.csl (#5087) 181c0dd Create apa-no.csl (#5059) 651ce48 Some fixes for Advanced Functional Materials (#5080) 4e3297a Acta Zoologica Hungarica: Don't demote nd particles c659df7 Create medicina-delle-dipendenze-italian-journal-of-the-addictions.csl (#5078) d243055 Update geografia-fisica-e-dinamica-quaternaria.csl (#5079) 1ee3809 Update mcgill-en.csl (#5076) 949cdc6 Update mcgill-fr.csl (#5075) ee7d4e1 Create chem-catalysis.csl (#5074) ec9faec Switch Molecular Therapy to Cell (#5070) cf6034c Switch Elsevier to their own ad-vancouver (#5072) 78cca13 Updates in research-institute-for-nature-and-forest.csl (#4958) 68b7478 Update journal-of-neolithic-archaeology.csl (#5065) 524ba93 Create offa.csl (#5066) 9713a82 Update associacao-brasileira-de-normas-tecnicas-ufrgs-note-initials-with-ibid (#5067) 44449df Uodate associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (#5061) baf9efa Create İstanbul Üniversitesi Sosyal Bilimler Enstitüsü Ali Ekber Çına… (#5064) c5c3531 Fix CORR 853a804 Major Update mcgill-fr.csl to 9th ed. (#5057) d3e2cd9 Update mcgill-en.csl (#5056) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 5c376b8
github-actions Bot
pushed a commit
to dimitra-karadima/jabref
that referenced
this pull request
Nov 15, 2020
55200d0 Create computational-intelligence.csl (JabRef#5102) 6d2efc3 Merge branch 'master' of github.com:citation-style-language/styles 60ab0fb Add Steinbeis SMI d5e0130 Add AAQR Style d964f9b Create bitonline-publikationen.csl (JabRef#5090) 0dc1a56 Add "APA 7th edition" to Norsk APA style titles (JabRef#5098) 3b6aaf7 Update norsk-apa-manual.csl (JabRef#5095) 0139c63 Create technische-universitat-dresden-betriebswirtschaftslehre-rechnungswesen-controlling.csl (JabRef#5034) fdc4497 Update universidade-estadual-de-alagoas-abnt (JabRef#5085) afdc2ea Create revista-espanola-de-nutricion-humana-y-dietetica.csl (JabRef#5082) 939189d Create citation-compass-apa-note-no.csl (JabRef#5060) 414f5e6 brazilian-journal-of-veterinary-research: add bib sorting (JabRef#5091) dbae9d7 Add DOI to Thieme German f4399aa APA: match="any" bugfixes (JabRef#5092) d0cc2c4 Add APA numeric and update BioEssays (JabRef#5089) 5c376b8 Create karlstad-universitet-kau-harvard-swedish.csl (JabRef#5083) 6a62c24 Create ucl-institute-of-education-harvard.csl (JabRef#5084) 4d1bbb0 Update ferdinand-porsche-fern-fachhochschule.csl (JabRef#5073) 3a9f494 Update cureus.csl (JabRef#5087) 181c0dd Create apa-no.csl (JabRef#5059) 651ce48 Some fixes for Advanced Functional Materials (JabRef#5080) 4e3297a Acta Zoologica Hungarica: Don't demote nd particles c659df7 Create medicina-delle-dipendenze-italian-journal-of-the-addictions.csl (JabRef#5078) d243055 Update geografia-fisica-e-dinamica-quaternaria.csl (JabRef#5079) 1ee3809 Update mcgill-en.csl (JabRef#5076) 949cdc6 Update mcgill-fr.csl (JabRef#5075) ee7d4e1 Create chem-catalysis.csl (JabRef#5074) ec9faec Switch Molecular Therapy to Cell (JabRef#5070) cf6034c Switch Elsevier to their own ad-vancouver (JabRef#5072) 78cca13 Updates in research-institute-for-nature-and-forest.csl (JabRef#4958) 68b7478 Update journal-of-neolithic-archaeology.csl (JabRef#5065) 524ba93 Create offa.csl (JabRef#5066) 9713a82 Update associacao-brasileira-de-normas-tecnicas-ufrgs-note-initials-with-ibid (JabRef#5067) 44449df Uodate associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#5061) baf9efa Create İstanbul Üniversitesi Sosyal Bilimler Enstitüsü Ali Ekber Çına… (JabRef#5064) c5c3531 Fix CORR 853a804 Major Update mcgill-fr.csl to 9th ed. (JabRef#5057) d3e2cd9 Update mcgill-en.csl (JabRef#5056) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 55200d0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5036
The problem is that the Maintable findentry() method does not find the new entry.
Further debugging showed that the Observable List with the entries in the maintable model does not yet include the new inserted entry, although it's already in the bib database.
This is because due to the Bindings.forUI around the list in MainTable, it's run on the FX thread. And the FX thread is blocked/busy with the findEntry method.
I know this was added because of not on fx thread exceptions. But I tested cleanup and external modification of file and it was fine. I think the key problem was the old swing stuff at that time.