Adding DOI to test entry - fixes #5013 by matthiasgeiger · Pull Request #5014 · JabRef/jabref

matthiasgeiger · 2019-05-31T06:49:19Z

One liner to have also a DOI available in the entry to test the preview function.

@noMicrosoftBuhtz any more suggestions what should be added?

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

buhtz · 2019-05-31T11:00:09Z

Thanks a lot.

I would like to have some comments (In the past it was notes, wasn't it?) and groups and keywords.

How could we handle issue? As I understand biblatex issue is used when number and volume does not exists and vis-a-vis. I also know that some journals or import/export mechanism generates entries with all three attributes.

If we are still in wish-mode...
What is about the getTestEntryBook(). Is it still used?
Beside an @article I would like to see a testentry for @InCollection (of course combined with a @Collection entry.

matthiasgeiger · 2019-05-31T18:42:01Z

Only three wishes! ;-)

I also added issue, keywords and comment to the test entry.

groups in general would also be possible - but as there are different ways to configure groups (e.g., based on keywords, etc.) it's hard to configure a preview to show all possibilities.

The getTestEntryBook() method is used in the LibreOffice settings - but not in the entry preview preferences.

26265bf Create pacific-science.csl (JabRef#5020) e6ff62e Update pravnik.csl & iso690-full-note-cs.csl (JabRef#5019) 8ab9362 Create turabian-9-author-date (JabRef#4796) 28c7021 Update west-european-politics.csl (JabRef#4900) 6d06e5e Create american-physical-society-et-al (JabRef#4974) 7472744 Create farmeconomia.csl (JabRef#5017) bd916df Create amerindia.csl (JabRef#5011) 28d176d Create law-technology-and-humans-journal-style.csl (JabRef#5015) a998aa5 Create kerala-journal-of-ophthalmology.csl (JabRef#5014) 8662257 Update journal-of-australian-strength-and-conditioning.csl (JabRef#5010) e28f06f Create clinical-management-issues.csl (JabRef#5008) abb92fb Create institut-francais-darcheologie-orientale-en.csl (JabRef#4870) f931c78 Update institut-francais-darcheologie-orientale.csl (JabRef#4869) 9d604ca Update journal-of-foraminiferal-research.csl 1191d07 add Journal of Foraminiferal Research (JabRef#5007) 0903e9d Update molecular-therapy.csl (JabRef#5009) 316d6c7 Update journal-of-alzheimers-disease.csl (JabRef#5006) 868a7ed Create journal-of-soil-science-and-plant-nutrition (JabRef#5005) 875ef81 Create universitat-bern-institut-fur-sozialanthropologie.csl (JabRef#4998) 1194b81 Create journal-de-la-societe-des-americanistes.csl (JabRef#4995) 1d2a472 Update international-energy-agency-organisation-for-economic-co-operation-and-development.csl (JabRef#4999) 02a26ef Update iso690-author-date-cs.csl (JabRef#5003) 165592c Create european-journal-of-entomology.csl (JabRef#5001) 4d587ca Create european-journal-of-anaesthesiology.csl (JabRef#5002) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 26265bf

26265bf Create pacific-science.csl (#5020) e6ff62e Update pravnik.csl & iso690-full-note-cs.csl (#5019) 8ab9362 Create turabian-9-author-date (#4796) 28c7021 Update west-european-politics.csl (#4900) 6d06e5e Create american-physical-society-et-al (#4974) 7472744 Create farmeconomia.csl (#5017) bd916df Create amerindia.csl (#5011) 28d176d Create law-technology-and-humans-journal-style.csl (#5015) a998aa5 Create kerala-journal-of-ophthalmology.csl (#5014) 8662257 Update journal-of-australian-strength-and-conditioning.csl (#5010) e28f06f Create clinical-management-issues.csl (#5008) abb92fb Create institut-francais-darcheologie-orientale-en.csl (#4870) f931c78 Update institut-francais-darcheologie-orientale.csl (#4869) 9d604ca Update journal-of-foraminiferal-research.csl 1191d07 add Journal of Foraminiferal Research (#5007) 0903e9d Update molecular-therapy.csl (#5009) 316d6c7 Update journal-of-alzheimers-disease.csl (#5006) 868a7ed Create journal-of-soil-science-and-plant-nutrition (#5005) 875ef81 Create universitat-bern-institut-fur-sozialanthropologie.csl (#4998) 1194b81 Create journal-de-la-societe-des-americanistes.csl (#4995) 1d2a472 Update international-energy-agency-organisation-for-economic-co-operation-and-development.csl (#4999) 02a26ef Update iso690-author-date-cs.csl (#5003) 165592c Create european-journal-of-entomology.csl (#5001) 4d587ca Create european-journal-of-anaesthesiology.csl (#5002) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 26265bf

26265bf Create pacific-science.csl (JabRef#5020) e6ff62e Update pravnik.csl & iso690-full-note-cs.csl (JabRef#5019) 8ab9362 Create turabian-9-author-date (JabRef#4796) 28c7021 Update west-european-politics.csl (JabRef#4900) 6d06e5e Create american-physical-society-et-al (JabRef#4974) 7472744 Create farmeconomia.csl (JabRef#5017) bd916df Create amerindia.csl (JabRef#5011) 28d176d Create law-technology-and-humans-journal-style.csl (JabRef#5015) a998aa5 Create kerala-journal-of-ophthalmology.csl (JabRef#5014) 8662257 Update journal-of-australian-strength-and-conditioning.csl (JabRef#5010) e28f06f Create clinical-management-issues.csl (JabRef#5008) abb92fb Create institut-francais-darcheologie-orientale-en.csl (JabRef#4870) f931c78 Update institut-francais-darcheologie-orientale.csl (JabRef#4869) 9d604ca Update journal-of-foraminiferal-research.csl 1191d07 add Journal of Foraminiferal Research (JabRef#5007) 0903e9d Update molecular-therapy.csl (JabRef#5009) 316d6c7 Update journal-of-alzheimers-disease.csl (JabRef#5006) 868a7ed Create journal-of-soil-science-and-plant-nutrition (JabRef#5005) 875ef81 Create universitat-bern-institut-fur-sozialanthropologie.csl (JabRef#4998) 1194b81 Create journal-de-la-societe-des-americanistes.csl (JabRef#4995) 1d2a472 Update international-energy-agency-organisation-for-economic-co-operation-and-development.csl (JabRef#4999) 02a26ef Update iso690-author-date-cs.csl (JabRef#5003) 165592c Create european-journal-of-entomology.csl (JabRef#5001) 4d587ca Create european-journal-of-anaesthesiology.csl (JabRef#5002) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 26265bf

Adding DOI to test entry - fixes #5013

0f8b3b3

Siedlerchr approved these changes May 31, 2019

View reviewed changes

add additional fields to TestEntry

1998843

use 3 as issue in order not to break CSL tests

c6caee7

tobiasdiez approved these changes May 31, 2019

View reviewed changes

matthiasgeiger merged commit f2530da into master May 31, 2019

matthiasgeiger deleted the fix-5013 branch May 31, 2019 20:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding DOI to test entry - fixes #5013#5014

Adding DOI to test entry - fixes #5013#5014
matthiasgeiger merged 3 commits into
masterfrom
fix-5013

matthiasgeiger commented May 31, 2019

Uh oh!

buhtz commented May 31, 2019

Uh oh!

matthiasgeiger commented May 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

matthiasgeiger commented May 31, 2019

Uh oh!

buhtz commented May 31, 2019

Uh oh!

matthiasgeiger commented May 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants