NPE-fix for Preferences/Ext-Prog/Settings for X/Browse by calixtus · Pull Request #4983 · JabRef/jabref

calixtus · 2019-05-19T16:09:14Z

Title should be self-explanatory, dialogservice was not initialized.
As it was working in 4.3.1, there is no need to put the fix in the Changelog.

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez

Thanks for your PR. I've one suggestion for improvement, otherwise it looks good.

calixtus · 2019-05-19T21:38:49Z

I realized, pushApplications is a static manager in JabRefFrame and I don't wonna change something on this big level. I tried a diffrent solution, using Constructors - as asked. It's been a bit tricky.
Thoughts?

calixtus · 2019-05-20T13:43:08Z

Done a small identifier reword, to keep it consistent, should be ready to review now.

…t-browse

Siedlerchr · 2019-05-20T20:15:36Z

Just one little further optimiation, but otherwise looks good and seems like the best solution so far.
Thanks for your contribution!

Siedlerchr

lgtm now :)

calixtus · 2019-05-21T07:12:21Z

Oh dear, that was kind of confusing... Never really worked with mixed static classes and instances of it.
But I am happy if it's fine now.

Siedlerchr · 2019-05-21T07:23:18Z

@calixtus Yeah, I know. And this class is not really that easy to understand with the hierarchy and the dialogServie argument which is passed along. But glad you spotted and fixed the dialogService error. :)

I don't know how experienced you are with Java, but I can really recommend this book here, which is written by JabRef (ex) developers: https://www.amazon.com/Java-Comparison-Become-Craftsman-Examples/dp/1680502875

calixtus · 2019-05-21T07:34:09Z

I studied computer science (Informatik) for one year in 2004-2005 in Passau and I had some Java lessons before I changed the subject of my studies, but it's way to long ago to remember all the details. I am doing this here in my leasure time.
Maybe i'm going to take a look into the book. Thank's for your advice.

tobiasdiez

That's looks perfect now. Thanks again!

* upstream/master: Fix background color of dialogs in dark mode (#4994) NPE-fix for Preferences/Ext-Prog/Settings for X/Browse (#4983) Bump richtextfx from 0.10.0 to 0.10.1 (#4989) Bump tika-core from 1.20 to 1.21 (#4984)

* 'ieeFix' of github.com:JabRef/jabref: Fix the 'Attach file' dialog for starting on the user's main directory (#4996) Readme TOC (#4986) Fix icon size - the second (#4993) Fix background color of dialogs in dark mode (#4994) NPE-fix for Preferences/Ext-Prog/Settings for X/Browse (#4983) Bump richtextfx from 0.10.0 to 0.10.1 (#4989) Bump tika-core from 1.20 to 1.21 (#4984) Resize different fonts changing entry type (#4980) Extended Hints - Alternative to #4971 (#4975) Fix command line help text (#4979)

93469bb Create journal-of-musculoskeletal-research.csl (#4990) 43287c7 Update taxon.csl a little more (#4989) 9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (#4982) 00c3cec Update isnad-metinici.csl (#4988) 864a64c Update medicine-and-science-in-sports-and-exercise.csl (#4983) 0c76011 Don't demote particles in Equine Vet J (#4984) 603ee73 Fix MLA editor translator (#4985) 40d207c Update pravnik.csl (#4986) c5fe30c Update isnad-dipnotlu.csl (#4987) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 93469bb

fad76fe Update Gemfile.lock a8dafef Update harvard-cite-them-right.csl (JabRef#4993) c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991) 197ec0e Update circulation-journal.csl (JabRef#4994) f36dabe Update American Physical Society dependents (JabRef#4992) 93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990) 43287c7 Update taxon.csl a little more (JabRef#4989) 9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982) 00c3cec Update isnad-metinici.csl (JabRef#4988) 864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983) 0c76011 Don't demote particles in Equine Vet J (JabRef#4984) 603ee73 Fix MLA editor translator (JabRef#4985) 40d207c Update pravnik.csl (JabRef#4986) c5fe30c Update isnad-dipnotlu.csl (JabRef#4987) 469deb6 Sage Harvard: Add translator/editor 1f51ef8 Add Pensoft dependents (JabRef#4981) 5338ff6 Create electrophoresis.csl (JabRef#4883) 4de9a97 Update spec_helper.rb fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928) 69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927) d807202 Changes to match Taxon guidelines for authors (JabRef#4980) aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962) 16f58df Update American Physical Society styles (JabRef#4794) b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963) 81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979) 0895562 Create pensoft-journals.csl (JabRef#4972) 4f8fa44 creates the gigascience.csl file (JabRef#4961) 1b9c7a0 Create acta-ornithologica.csl (JabRef#4977) c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: fad76fe

Added handover dialogservice

eb8f81f

tobiasdiez requested changes May 19, 2019

View reviewed changes

Comment thread src/main/java/org/jabref/gui/push/PushToApplicationSettings.java Outdated

calixtus changed the title ~~NPE-fix for Preferences/Ext-Prog/Settings for X/Browse~~ [WIP] NPE-fix for Preferences/Ext-Prog/Settings for X/Browse May 19, 2019

calixtus added 2 commits May 19, 2019 23:36

Undone previous

c79ce54

Refactor Constructors, handing over dialogService

34bef06

calixtus changed the title ~~[WIP] NPE-fix for Preferences/Ext-Prog/Settings for X/Browse~~ NPE-fix for Preferences/Ext-Prog/Settings for X/Browse May 19, 2019

Reword Identifier

a363f5c

Siedlerchr requested changes May 20, 2019

View reviewed changes

Comment thread src/main/java/org/jabref/gui/push/AbstractPushToApplication.java

calixtus added 2 commits May 20, 2019 21:31

Reformat for codestyle

12c14ab

Merge remote-tracking branch 'upstream/master' into fix-prefs-extp-se…

37b5a68

…t-browse

Siedlerchr reviewed May 20, 2019

View reviewed changes

Comment thread src/main/java/org/jabref/gui/push/PushToApplicationsManager.java Outdated

Refactor Constructors

c456701

calixtus force-pushed the fix-prefs-extp-set-browse branch from ec888f1 to c456701 Compare May 20, 2019 22:51

calixtus added 3 commits May 21, 2019 00:53

Delete superfluous import for checkstyle

f8dcd0c

Reformat whitespace

d689d44

Refactor Constructors

be06f58

Siedlerchr reviewed May 21, 2019

View reviewed changes

Comment thread src/main/java/org/jabref/gui/push/PushToApplicationsManager.java

Refactor Cleanup

ee82c45

Siedlerchr approved these changes May 21, 2019

View reviewed changes

tobiasdiez approved these changes May 21, 2019

View reviewed changes

tobiasdiez merged commit 9322cde into JabRef:master May 21, 2019

calixtus deleted the fix-prefs-extp-set-browse branch May 21, 2019 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

NPE-fix for Preferences/Ext-Prog/Settings for X/Browse #4983

NPE-fix for Preferences/Ext-Prog/Settings for X/Browse #4983
tobiasdiez merged 11 commits into
JabRef:masterfrom
calixtus:fix-prefs-extp-set-browse

calixtus commented May 19, 2019

Uh oh!

tobiasdiez left a comment

Uh oh!

Uh oh!

calixtus commented May 19, 2019 •

edited

Loading

Uh oh!

calixtus commented May 20, 2019

Uh oh!

Uh oh!

Uh oh!

Siedlerchr commented May 20, 2019

Uh oh!

Uh oh!

Siedlerchr left a comment

Uh oh!

calixtus commented May 21, 2019

Uh oh!

Siedlerchr commented May 21, 2019

Uh oh!

calixtus commented May 21, 2019

Uh oh!

tobiasdiez left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

calixtus commented May 19, 2019

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

calixtus commented May 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

calixtus commented May 20, 2019

Uh oh!

Uh oh!

Uh oh!

Siedlerchr commented May 20, 2019

Uh oh!

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

calixtus commented May 21, 2019

Uh oh!

Siedlerchr commented May 21, 2019

Uh oh!

calixtus commented May 21, 2019

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

calixtus commented May 19, 2019 •

edited

Loading