Improve full text search for several files#4855
Merged
Siedlerchr merged 3 commits intoApr 18, 2019
Merged
Conversation
Siedlerchr
approved these changes
Apr 18, 2019
Siedlerchr
added a commit
that referenced
this pull request
Apr 20, 2019
* upstream/master: Fix Some Codacy Code Convention Issues (#4904) Bump ridl from 6.2.2 to 6.2.3 (#4903) Bump juh from 6.2.2 to 6.2.3 (#4902) Bump jurt from 6.2.2 to 6.2.3 (#4901) Bump unoil from 6.2.2 to 6.2.3 (#4900) Bump richtextfx from 0.9.3 to 0.10.0 (#4899) Store column widths as integer (#4896) Improve full text search for several files (#4855)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution proposal for #4854
In
FindFullTextAction,Taskis now used instead ofBackgroundTaskto be able to show a progress dialog which shows the progress for searching files online.Furthermore, the functionality for downloading a file in
LinkedFileViewModelis split intodownloadandprepareDownloadTaskto be able to define a custom onSucess-action for the background task. This is used inFindFullTextActionto add the downloaded file to the entry instead of the URL.The functionality provided by
LinkedFileViewModel.dowloadremains as it is, so it does not affect the download of a single file via the EntryEditor.