Use action handler#4726
Merged
Merged
Conversation
Siedlerchr
approved these changes
Mar 8, 2019
Member
|
Please fix the checkstlye issue (unused import) and it can be merged. |
tobiasdiez
requested changes
Mar 8, 2019
| keywordGroupRegExp.setOnAction(actionHandler); | ||
| searchGroupSearchExpression.setOnAction(actionHandler); | ||
| searchGroupRegExp.setOnAction(actionHandler); | ||
| searchGroupRegExp.setOnAction(actionHandler); |
Member
There was a problem hiding this comment.
searchGroupRegExp is set twice (not your fault, was the case already in the existing code...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a problem in which the Add Group Dialog was processing text fields for each keystroke typed in them rather than when the user was done typing. This would throw errors when the user's partially-typed answer was invalid. I changed this by using
EventHandlers instead ofListeners.This may already have been fixed by the recent change to the dialog, but this PR shouldn't hurt anyway, since the fields will only be updated when the user is finished typing.