Skip to content

Fix entry preview copy exception#4721

Merged
Siedlerchr merged 4 commits into
masterfrom
fixpreviewcopy
Mar 8, 2019
Merged

Fix entry preview copy exception#4721
Siedlerchr merged 4 commits into
masterfrom
fixpreviewcopy

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

Fixes #4714


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 5, 2019

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting rid of this god-damn Swing worker ;-).

Comment thread src/main/java/org/jabref/gui/worker/CitationStyleToClipboardWorker.java Outdated
* upstream/master:
  Fix default import format pattern (#4731)
  Add key bindings (#4732)
  Convert "wait for save" dialog to JavaFX (#4697)
  Adding additional modifiers to be used in bibtex key generator
  Adding "von" part to Author's last name when exporting to MS Office 2007 (#4725)
  Bump mockito-core from 2.24.5 to 2.25.0 (#4723)
  remove obsolete localization strings fix checkstyle
  fix build
  cleanup
  convert file chooser in preferences
  remove unused swing stuff convert help  buttons

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that works too.

Comment thread src/main/java/org/jabref/gui/worker/CitationStyleToClipboardWorker.java Outdated
Comment thread src/main/java/org/jabref/gui/worker/CitationStyleToClipboardWorker.java Outdated
@Siedlerchr Siedlerchr merged commit 7650a9f into master Mar 8, 2019
@Siedlerchr Siedlerchr deleted the fixpreviewcopy branch March 8, 2019 13:10
Siedlerchr added a commit that referenced this pull request Mar 8, 2019
…tofx

* upstream/master: (25 commits)
  Convert "Manage external file types" dialog to JavaFX (#4711)
  Remove add/move/remove from group dialog (#4695)
  Fix entry preview copy exception (#4721)
  Fix default import format pattern (#4731)
  Add key bindings (#4732)
  Convert "wait for save" dialog to JavaFX (#4697)
  Add changes to CHANGELOG and fix New Library icons
  Adding GENERATE_CITE_KEYS button to toolbar.
  Change toolbar icons and add separators
  Adding additional modifiers to be used in bibtex key generator
  Adding "von" part to Author's last name when exporting to MS Office 2007 (#4725)
  Bump mockito-core from 2.24.5 to 2.25.0 (#4723)
  remove obsolete localization strings fix checkstyle
  fix build
  cleanup
  convert file chooser in preferences
  remove unused swing stuff convert help  buttons
  Fix #4703: Newline format couldn't be changed (#4720)
  Group and reorder the Main Menu (tabs & icons) (#4707)
  Convert Manage keywords dialog to JavaFX (#4701)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants