Fix: bibkey generated does not handle diacritics by chel-seyy · Pull Request #4713 · JabRef/jabref

chel-seyy · 2019-03-03T10:45:35Z

Fixes #4709.
Clean up the author value in BracketedPattern after it is retrieved from the BibEntry.

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

Siedlerchr · 2019-03-03T10:59:05Z

Thanks for your contribution. Unfortunately your changes resulted in a lot of failed tests (look at Details of the travis build and then select the failing job)
Seems like there are some more cases you need to take care of. (I'm not that deep into the bibtexkeygenerator stuff)

chel-seyy · 2019-03-03T14:15:34Z

Noted. Is there another approach to handle this?

tobiasdiez

It should suffice to add the cleankey statement here: https://github.com/JabRef/jabref/pull/4713/files#diff-fee188bf55aacff33f887a63d6b72605R234
(and also remove other symbols such as - and whitespace).

Please also create a few tests in https://github.com/JabRef/jabref/pull/4713/files#diff-fee188bf55aacff33f887a63d6b72605R234. Thanks!

chel-seyy · 2019-03-08T01:12:22Z

Currently facing some issues while writing tests: mockito and jfoenix.controls.JFXSnackbarLayout cannot be imported, whereas jfoenix.controls.JFXSnackbar.SnackbarEvent works fine.
I updated to jdk8_202 and it doesn't help.
Just reimported the project, it works now.
After syncing fork, the same error occurs. How to fix this?

Siedlerchr · 2019-03-08T07:28:24Z

@chelseyong Try merging the current master in e.g. (if upstream is the jabref/jabref repo)

git fetch upstream 
git merge upstream/master

I'm not an intellij user, but executing gradle should be sufficient.
maybe @halirutan can tell you more.

chel-seyy · 2019-03-10T02:40:21Z

Sorry for the delay, I had some software issues.

Symbol - is now removed from key generation.

tobiasdiez

Looks good to me. Thanks for your contribution!

tobiasdiez · 2019-03-10T08:35:01Z

    }

-    public static String cleanKey(String key, boolean enforceLegalKey) {
+    public static String filterUnwantedCharacters(String key, boolean enforceLegalKey) {


maybe a slightly better name removeUnwantedCharacters (filter would imply that the unwanted characters are returned).

Siedlerchr

Thank you very much for your contribution!
lgtm

koppor · 2020-04-16T20:50:55Z

    private static final Logger LOGGER = LoggerFactory.getLogger(BibtexKeyGenerator.class);
-    private static final String KEY_ILLEGAL_CHARACTERS = "{}(),\\\"#~^':`";
-    private static final String KEY_UNWANTED_CHARACTERS = "{}(),\\\"";
+    private static final String KEY_ILLEGAL_CHARACTERS = "{}(),\\\"-#~^':`";


@chelseyong Do you, by chance, remember why you introduced - here? We have issues with that. See #6295 for details.

I think it is due to a suggestion made in the issue.

Al-Ketan, 2019 -> Al-19 (dash in bibtex key is awkward, should probably be ignored in favor of the next letter and become AlK19)

Thank you for your reply. I Think, there was some misunderstanding at #4709 (comment)

Well, dash is a perfectly legal char

We will fix it at #6300

143464e Fix comma before et al. for the-oncologist.csl (#4724) 3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (#4719) b2c0c1e APA: in-text title in title-case (#4725) 88c68d2 Fix et-al and indetation settings for mammalia.csl (#4717) 05940a2 Update the-febs-journal.csl (#4720) 1d77ba8 Request for review and assessment of the repa.csl (#4698) 76b4be5 Update isnad.csl (#4716) f709c84 Update isnad-dipnotlu.csl (#4715) 45d7655 Create mammalia.csl (#4714) eb333ca Update society-for-american-archaeology.csl (#4710) d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (#4712) 5e34eb1 Update animal-welfare.csl (#4713) 06785fa Update le-tapuscrit-author-date.csl (#4708) ada5282 Update norois.csl (#4707) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 143464e

906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730) 607a056 Create ifao-publications.csl (JabRef#4731) 5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735) 4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734) d70c2a4 Add chapter section in bibliography (JabRef#4732) 366dbc1 Create economic-history-review.csl (JabRef#4643) 7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711) a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729) 143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724) 3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719) b2c0c1e APA: in-text title in title-case (JabRef#4725) 88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717) 05940a2 Update the-febs-journal.csl (JabRef#4720) 1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698) 76b4be5 Update isnad.csl (JabRef#4716) f709c84 Update isnad-dipnotlu.csl (JabRef#4715) 45d7655 Create mammalia.csl (JabRef#4714) eb333ca Update society-for-american-archaeology.csl (JabRef#4710) d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712) 5e34eb1 Update animal-welfare.csl (JabRef#4713) 06785fa Update le-tapuscrit-author-date.csl (JabRef#4708) ada5282 Update norois.csl (JabRef#4707) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 906cd6d

906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730) 607a056 Create ifao-publications.csl (JabRef#4731) 5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735) 4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734) d70c2a4 Add chapter section in bibliography (JabRef#4732) 366dbc1 Create economic-history-review.csl (JabRef#4643) 7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711) a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729) 143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724) 3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719) b2c0c1e APA: in-text title in title-case (JabRef#4725) 88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717) 05940a2 Update the-febs-journal.csl (JabRef#4720) 1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698) 76b4be5 Update isnad.csl (JabRef#4716) f709c84 Update isnad-dipnotlu.csl (JabRef#4715) 45d7655 Create mammalia.csl (JabRef#4714) eb333ca Update society-for-american-archaeology.csl (JabRef#4710) d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712) 5e34eb1 Update animal-welfare.csl (JabRef#4713) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 906cd6d

906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730) 607a056 Create ifao-publications.csl (JabRef#4731) 5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735) 4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734) d70c2a4 Add chapter section in bibliography (JabRef#4732) 366dbc1 Create economic-history-review.csl (JabRef#4643) 7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711) a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729) 143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724) 3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719) b2c0c1e APA: in-text title in title-case (JabRef#4725) 88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717) 05940a2 Update the-febs-journal.csl (JabRef#4720) 1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698) 76b4be5 Update isnad.csl (JabRef#4716) f709c84 Update isnad-dipnotlu.csl (JabRef#4715) 45d7655 Create mammalia.csl (JabRef#4714) eb333ca Update society-for-american-archaeology.csl (JabRef#4710) d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712) 5e34eb1 Update animal-welfare.csl (JabRef#4713) 06785fa Update le-tapuscrit-author-date.csl (JabRef#4708) ada5282 Update norois.csl (JabRef#4707) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 906cd6d

Clean key in BracketedPattern after author value is retrieved

0313b4e

tobiasdiez reviewed Mar 3, 2019

View reviewed changes

Shift cleaning of authString to authN only

7d8de04

chel-seyy changed the title ~~Fix: bibkey generated does not handle diacritics~~ [WIP] Fix: bibkey generated does not handle diacritics Mar 5, 2019

Extract authN method

fa73ea0

chel-seyy added 4 commits March 10, 2019 09:56

Filter unwanted characters before removing whitespaces

03fc076

Update test cases

a0219f3

Remove -s from key

89a398b

Remove the dashes from test case

e3e6961

chel-seyy changed the title ~~[WIP] Fix: bibkey generated does not handle diacritics~~ Fix: bibkey generated does not handle diacritics Mar 10, 2019

tobiasdiez approved these changes Mar 10, 2019

View reviewed changes

Rename method to removeUnwantedCharacters

f414a96

Siedlerchr approved these changes Mar 10, 2019

View reviewed changes

Siedlerchr merged commit c75481f into JabRef:master Mar 10, 2019

Siedlerchr mentioned this pull request Mar 10, 2019

Revert "Fix: bibkey generated does not handle diacritics" #4741

Merged

koppor reviewed Apr 16, 2020

View reviewed changes

koppor mentioned this pull request Apr 16, 2020

dash should not be reported as illegal BibTeX-Key #6295

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: bibkey generated does not handle diacritics#4713

Fix: bibkey generated does not handle diacritics#4713
Siedlerchr merged 8 commits into
JabRef:masterfrom
chel-seyy:handling-diacritics-4709

chel-seyy commented Mar 3, 2019 •

edited

Loading

Uh oh!

Siedlerchr commented Mar 3, 2019

Uh oh!

chel-seyy commented Mar 3, 2019

Uh oh!

tobiasdiez left a comment

Uh oh!

chel-seyy commented Mar 8, 2019 •

edited

Loading

Uh oh!

Siedlerchr commented Mar 8, 2019

Uh oh!

chel-seyy commented Mar 10, 2019

Uh oh!

tobiasdiez left a comment

Uh oh!

tobiasdiez Mar 10, 2019

Uh oh!

Siedlerchr left a comment

Uh oh!

koppor Apr 16, 2020

Uh oh!

chel-seyy Apr 17, 2020

Uh oh!

koppor Apr 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

chel-seyy commented Mar 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Mar 3, 2019

Uh oh!

chel-seyy commented Mar 3, 2019

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

chel-seyy commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Mar 8, 2019

Uh oh!

chel-seyy commented Mar 10, 2019

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

tobiasdiez Mar 10, 2019

Choose a reason for hiding this comment

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

koppor Apr 16, 2020

Choose a reason for hiding this comment

Uh oh!

chel-seyy Apr 17, 2020

Choose a reason for hiding this comment

Uh oh!

koppor Apr 17, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chel-seyy commented Mar 3, 2019 •

edited

Loading

chel-seyy commented Mar 8, 2019 •

edited

Loading