Create test#4518
Merged
Merged
Conversation
tobiasdiez
approved these changes
Nov 28, 2018
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks! The changes look fine to me.
tobiasdiez
reviewed
Nov 28, 2018
| private JabRefFrame jabRefFrame = mock(JabRefFrame.class); | ||
| private DialogService dialogService = mock(DialogService.class); | ||
| private BibDatabaseContext bibDatabaseContext = mock(BibDatabaseContext.class); | ||
| private Optional<Path> databasePath = Optional.of(new File("C:\\Users\\John_Doe\\Jabref").toPath()); |
Siedlerchr
approved these changes
Nov 29, 2018
Siedlerchr
added a commit
that referenced
this pull request
Dec 23, 2018
* upstream/master: Correct PNAS abbrev. (#4524) Create test (#4518) Bump junit-jupiter-params from 5.3.1 to 5.3.2 (#4514) Bump junit-vintage-engine from 5.3.1 to 5.3.2 (#4511) Bump junit-jupiter-engine from 5.3.1 to 5.3.2 (#4513) Bump richtextfx from 0.9.1 to 0.9.2 (#4512) Bump junit-jupiter-api from 5.3.1 to 5.3.2 (#4510) Bump junit-platform-launcher from 1.3.1 to 1.3.2 (#4515)
Siedlerchr
added a commit
that referenced
this pull request
Dec 28, 2018
* upstream/master: (49 commits) improve styling of preferences side menu (#4556) Cleanup interfaces (#4553) Bump fontbox from 2.0.12 to 2.0.13 (#4552) Bump pdfbox from 2.0.12 to 2.0.13 (#4551) Bump wiremock from 2.19.0 to 2.20.0 (#4550) Fixes that renaming a group did not change the group name in the interface (#4549) Bump applicationinsights-logging-log4j2 from 2.2.1 to 2.3.0 (#4540) Bump antlr4-runtime from 4.7.1 to 4.7.2 (#4542) Bump applicationinsights-core from 2.2.1 to 2.3.0 (#4541) Bump antlr4 from 4.7.1 to 4.7.2 (#4543) Fix journal name "Astronomy Journal" to "Astronomical Journal" fix-for-issue-4489 (#4538) Sorting of read-status isn't working as expected #4521 (#4536) Add preselect last used export format in export to clipboard dialog (#4533) fixed 4365 put html in clipboard (#4519) [WIP] Convert Exporter Customization Dialog to javafx (#4394) Fixes #4437 (#4531) Bump checkstyle from 8.14 to 8.15 (#4528) Correct PNAS abbrev. (#4524) Create test (#4518) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor and create test for
org.jabref.gui.exporter.SaveAllAction