Set auto-update checkbox enable/disable when reading preferences#4446
Merged
Conversation
…dent controls get updated. Drive-by code cleanup -- enums are singletons; don't call enum.equals(), just use ==.
Siedlerchr
reviewed
Nov 2, 2018
Siedlerchr
reviewed
Nov 3, 2018
Siedlerchr
requested changes
Nov 3, 2018
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
If you use javafx bindings, this should be better.
And please remove the changelog entry, as this issue was introduced with the conversion to javafx and therefore not present in the stable version
sbeitzel
commented
Nov 3, 2018
Member
|
Behavior should be |
tobiasdiez
approved these changes
Nov 6, 2018
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
This looks good to me. @Siedlerchr is this ok for merge?
Siedlerchr
approved these changes
Nov 6, 2018
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Forgot to approve the changes to the binding!
Siedlerchr
added a commit
that referenced
this pull request
Nov 10, 2018
* upstream/master: Fix move to group always moves first entry (#4457) Add eprint cleanup (#4445) respect preference state (#4468) Set auto-update checkbox enable/disable when reading preferences (#4446) Improve MathSciNet fetcher and add ISBN fetcher to entry editor toolbar (#4444) New translations JabRef_en.properties (German) (#4455)
Siedlerchr
added a commit
that referenced
this pull request
Nov 17, 2018
* upstream/master: Change location of some fields in the entry editor (#4448) Bump applicationinsights-core from 2.2.0 to 2.2.1 (#4488) Added feature to add server timezone when connecting to shared database (#4483) Bump applicationinsights-logging-log4j2 from 2.2.0 to 2.2.1 (#4487) fix save button Update archunit from 0.9.1 -> 0.9.2 Fix move to group always moves first entry (#4457) Add eprint cleanup (#4445) respect preference state (#4468) Set auto-update checkbox enable/disable when reading preferences (#4446) Improve MathSciNet fetcher and add ISBN fetcher to entry editor toolbar (#4444) New translations JabRef_en.properties (German) (#4455) New Crowdin translations (#4454) Fix error in l10n file: Toogle -> Toggle (#4453) Remove depandabot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses issue #4427. Added a call to the existing event handler (which enables/disables the checkbox in response to user clicks) when we set the checkbox value from the preferences.