Fix generate bibtex key overwrite warning dialog#4418
Merged
Conversation
tobiasdiez
requested changes
Oct 27, 2018
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Although this works, can please instead rework the TaskExecutor code using JavaFX tasks. I think, we are at a point where we can try to trough out swing instead of inserting runInJavaFXThread everywhere.
Member
Author
|
Well, it is already using the BackgroundTask.wrap to create a background thread, which has nothing to do with the swing stuff: Which of course creates a pool thread. I see no other way to show a dialog |
tobiasdiez
reviewed
Oct 27, 2018
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Just put the start of the generateKeys method that is related to the key overwrite dialog before the Background.wrap() statement. Anything in wrap should perform an action and only code in success or failure should be allowed to interact with the user.
put only generate action in background task
Siedlerchr
added a commit
that referenced
this pull request
Oct 27, 2018
* upstream/master: (30 commits) Update README.md (#4419) Fix generate bibtex key overwrite warning dialog (#4418) Fix group hit counter when adding entries (#4413) Update README.md fix java.nio.file.FileSystemNotFoundException and reorganize code (#4416) fixed an issue where corresponding groups are sometimes not highlighted when clicking on entries (#4404) Add a few journal abbreviations (#4412) Fix display of radio buttons (#4411) Update issue templates Delete ISSUE_TEMPLATE.md Update issue templates Integrate mrdlib redesign (#4361) fix "save" button in preference dialog not response (#4406) show dialog before creating entry (#4405) Scrollbar invisible in Preferences -> BibTex Key Pattern (#4287) (#4398) Updates (#4402) Fixes for all mods exporter tests (#4396) Fix EntryType dialog not closed after generate button (#4390) Make rank image narrower (#4395) Fix showing multiple icons for one menu entry - fixes #4384 (#4392) ...
Siedlerchr
added a commit
that referenced
this pull request
Oct 29, 2018
* upstream/master: (54 commits) Update README.md (#4419) Fix generate bibtex key overwrite warning dialog (#4418) Fix group hit counter when adding entries (#4413) Update README.md fix java.nio.file.FileSystemNotFoundException and reorganize code (#4416) fixed an issue where corresponding groups are sometimes not highlighted when clicking on entries (#4404) Add a few journal abbreviations (#4412) Fix display of radio buttons (#4411) Update issue templates Delete ISSUE_TEMPLATE.md Update issue templates Integrate mrdlib redesign (#4361) fix "save" button in preference dialog not response (#4406) show dialog before creating entry (#4405) Scrollbar invisible in Preferences -> BibTex Key Pattern (#4287) (#4398) Updates (#4402) Fixes for all mods exporter tests (#4396) Fix EntryType dialog not closed after generate button (#4390) Make rank image narrower (#4395) Fix showing multiple icons for one menu entry - fixes #4384 (#4392) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4417
The problem was that the GenerateBibtexKeyAction is executed using a TaskExecutor and therefore not run on the FX Thread. Unfortunately the exception was swallowed and not reported.