ArXiv fetcher support http url#4367
Merged
Merged
Conversation
tobiasdiez
requested changes
Oct 9, 2018
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution. The code looks good to me. Can you please add a changelog entry and a test analogous to
jabref/src/test/java/org/jabref/logic/importer/fetcher/ArXivTest.java
Lines 161 to 164 in d8d3807
Member
|
Yeah, looks good to me! I exactly had the same issue yesterday that I could not paste the whole url |
tobiasdiez
approved these changes
Oct 10, 2018
Siedlerchr
added a commit
that referenced
this pull request
Oct 13, 2018
* upstream/master: Update Libraries (#4366) ArXiv fetcher support http url (#4367) Fix issue 3861 : XMP Dialog, Add new Groups dialog, Append Library dialog to javafx (#4264) fix IndexOutOfBoundsException when saving preferences group RadioButtons in ExportSortingPrefsTab to prevent the selection of multiple or no order types Convert Part of the Issue#3861 Quality->Cleanup entries (#4268) UPDATE gradle to 4.10.2 (#4358) Completed General Fields Customizer conversion to JavaFX (#4346) Fix JavaFX thread exception when fetching new infos (#4354) Auto trim url field (#4355) Fix freezes in entry editor (#4351) # Conflicts: # src/main/java/org/jabref/preferences/PreferencesService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I wanted to fix the issue from koppor#328.
I simply used existing code in the same file which just takes the identifier at the end of the URL and perform a search.
For example: https://arxiv.org/abs/1802.01168 to 1802.01168
The error dialog does not appear anymore and a new entry is made.