Changed the behavior of the field formatting dialog#4275
Merged
Conversation
Siedlerchr
approved these changes
Aug 19, 2018
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! Lgtm! It would be nice if you could add a test case, too
There is already a test class for the cleanup operation. You can simply add a new test case
Contributor
Author
|
I created a few unit tests. For the last one, I hard coded the LaTeX version of the "ç" character. |
tobiasdiez
approved these changes
Aug 21, 2018
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Very good! Thanks for your contribution.
Contributor
Author
|
My pleasure! |
Siedlerchr
added a commit
that referenced
this pull request
Aug 24, 2018
* upstream/master: (129 commits) Fix Export to clipbaord action (#4286) Add minimal height for entry editor (#4283) Fix exceptions when trying to change settings (#4284) Added a comment for the purpose of the class (#4282) Fix NPE when importing from CLI (#4281) Fix display of key patterns convert bibtexkeypatterndlg to javafx as well (#4277) Style preference sections using css Fix a few style issues Changed the behavior of the field formatting dialog (#4275) Fix checkbox display Remove small font size Style side pane in preferences Wrap preference tabs in scrollpane Fix NPE with bibdatabasecontext in preview style dialog update xmlunit and log4j jul and checkstyle Update mysql driver to 8.0.12 Rework preference dialog main class Move preferences stuff to gui.preferences Implement drag and drop for maintable (#3765) ... # Conflicts: # src/main/java/org/jabref/gui/shared/ConnectToSharedDatabaseDialog.java
Siedlerchr
added a commit
that referenced
this pull request
Aug 29, 2018
* upstream/master: (468 commits) Fix error prone warnings (#4290) Fix freeze on import into current library (#4299) Upgrade gradle to 4.10 update xmlunit and postgres update xmlunit-matchers from 2.6.0 -> 2.6.1 update gradle build-scan from 1.15.2 -> 1.16 checkstyle execute changes only if disk db present Fix Export to clipbaord action (#4286) fix npe in Merge entries dialog Add minimal height for entry editor (#4283) Fix exceptions when trying to change settings (#4284) Added a comment for the purpose of the class (#4282) Fix NPE when importing from CLI (#4281) Fix display of key patterns convert bibtexkeypatterndlg to javafx as well (#4277) Style preference sections using css Fix a few style issues Changed the behavior of the field formatting dialog (#4275) Fix checkbox display Remove small font size ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the loops for formatting all fields in the FieldFormatterCleanup class test for not being the KEY_FIELD. I originally had this in the cleanupSingleString method to prevent KEY_FIELD from being cleaned up (reformatted) entirely, but decided to let the user specifically format that field. When the user chooses to format all fields at once, however, the KEY_FIELD will be not be reformatted. This solves issue #4148