Fix author list parser (#4169)#4248
Merged
Merged
Conversation
tobiasdiez
approved these changes
Aug 7, 2018
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks for the follow-up. The new fix looks good to me.
Please remove the additional changelog entry.
| - Window state is saved on close and restored on start. | ||
| - Files without a defined external file type are now directly opened with the default aplication of the operating system | ||
| - We streamlined the process to rename and move files by removing the confirmation dialogs. | ||
| - We removed the redundant new lines of markings and wrapped the summary in the File annotation tab. [#3823](https://github.com/JabRef/jabref/issues/3823) |
Member
There was a problem hiding this comment.
This comment is probably a leftover from the other PR.
Contributor
Author
There was a problem hiding this comment.
So what should I do after remove the additional changelog entry? Commit and push?
Contributor
Author
There was a problem hiding this comment.
This is my first time pull request.
Member
There was a problem hiding this comment.
Yes, everything is fine now. Thanks!
We will wait until a second developer gives a positive review before merge.
Contributor
Author
|
It is ok now? |
Siedlerchr
approved these changes
Aug 7, 2018
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Looks good to me! I think this is a really nice feature for people having papers from Chinese authors.
Siedlerchr
added a commit
that referenced
this pull request
Aug 8, 2018
Siedlerchr
added a commit
that referenced
this pull request
Aug 13, 2018
* upstream/master: (33 commits) Fix display of checkboxes Fix Remove Spin comments Fix#3861_build_addneeded/deleteobsoleteproperties2 Fix#3861_build_addneeded/deleteobsoleteproperties Fix#3861_build Fix attach file does not relativize file path (#4252) Fix for issue koppor 254 (Auto cleanup url) (#4255) Fix#ReplaceString_ChangeConflict Fix#3861ReplaceString_solveConflict Fix#3861RS_conflicttest Fix#3861RS_conflicttest Remove changelog entries Fix#3861ReplaceString_checkStyle Fix#3861ReplaceString_Improvements Fix#3861ReplaceString_ContributeLog fix log4j slf4j dependency Update dependencies (#4251) Fix author list parser (#4169) (#4248) ReplaceStringMVVMPattern ... # Conflicts: # src/main/java/org/jabref/gui/BasePanel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have fixed an issue where author list parser can't generate bibtexkey for Chinese author. #4169
Before fix:
The default bibtexkey is [author][year], actually it only shows [year]. Obviously the [author] can't be generated normally.
After fix:
Now it can generate bibtexkey for Chinese author.
We have used correct logic so that if author's name is not Chinese name, it won't do anything.